-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SKAdN in Bidding Only scenario #1086
Open
OlenaPostindustria
wants to merge
21
commits into
master
Choose a base branch
from
1085/support-skadn-in-bidding-only-scenario
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support SKAdN in Bidding Only scenario #1086
OlenaPostindustria
wants to merge
21
commits into
master
from
1085/support-skadn-in-bidding-only-scenario
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37294ec
to
1dfd418
Compare
45a0eaa
to
9785de1
Compare
9785de1
to
f7f7a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1085
Overview
The primary objective of this pull request is to facilitate the adoption of SKAdNetwork in a bidding-only scenario. This feature has been implemented to support banner, video, and native ad formats.
SKAdNetwork support is automatically enabled for all native ads. No additional steps are required.
seatbid[].bid[].ext.skadn
parameters and fidelity type is 1, the SDK will display aSKStoreProductViewController
with the appropriate product parameters when the user clicks on the ad.seatbid[].bid[].ext.skadn
parameters and fidelity type is 0, SKAdNetwork impression tracking begins when the SDK registers the corresponding event.Note: This PR does not include support for view-through ads because the SDK currently lacks the ability to track impression events for
bannerand video formats. Support for view-through ads will be implemented in a future update once the necessary changes are made (see issue #790 for details).The support for view-through ads was implemented for banner format.
To enable SKAdNetwork StoreKit ads support for banner ads, the publisher needs to call the method
activatePrebidSKAdNetworkStoreKitAdsFlow(adView:)
oractivatePrebidSKAdNetworkStoreKitAdsFlow()
of the respective ad unit within theGADBannerViewDelegate
methodbannerViewDidReceiveAd(_ bannerView: GADBannerView)
.The
PrebidSKAdNetworkHelper
will attempt to locate thehb_cache_id_local
key within the creative contained in the banner view. If the key is found, the SDK will retrieve the corresponding bid from the cache using this key, verify the presence ofseatbid[].bid[].ext.skadn
parameters, and create a transparent, click-through overlay view to track user interactions. When the SDK detects a user click, it will trigger the presentation of anSKStoreProductViewController
using the retrievedskadn
parameters.If the SDK is unable to find the
hb_cache_id_local
key in the creative (e.g., in the case of a video format), it will then attempt to locate thehb_uuid
key. The SDK will compare this key against the keys of bids stored in the cache to retrieve the corresponding bid information.Note: StoreKit ads are not supported for video ad format.