Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector script to use Async get eids function #40

Open
patmmccann opened this issue Apr 18, 2022 · 6 comments
Open

Collector script to use Async get eids function #40

patmmccann opened this issue Apr 18, 2022 · 6 comments
Assignees

Comments

@patmmccann
Copy link

prebid/Prebid.js#8201 allows the collection of eids async. This is more likely to resolve.

@jdwieland8282 @SKOCHERI

@patmmccann
Copy link
Author

const pubCommonUids = pbjs.getUserIdsAsEids().filter(function (eids) {

@dgirardi
Copy link

Without knowing what gpt expects I would not blindly switch to the async function; it will sometimes provide an id when the sync version wouldn't, but it will be much slower on average.

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Jul 18, 2022
@patmmccann
Copy link
Author

So this behavior(signal collection) is built with an asynchronous nature. It is better to populate the signal slowly than populate quickly and missing.

@dgirardi
Copy link

@patmmccann - what is this issue about? should it be in the shared-id repo?

@dgirardi dgirardi moved this from Ready for Dev to Needs Req in Prebid.js Tactical Issues table Aug 15, 2023
@jdwieland8282
Copy link
Member

Next steps:

  1. modify ob collector script to call async endpoint
  2. alert OB that we will be releasing a new version of the collector script
  3. coordinate the changes in fix: cope with pubCommonUids being an empty list #42 with OB as well.

@patmmccann
Copy link
Author

Should we simply deprecate this script? GAM can now find the sharedid

Image
https://support.google.com/admanager/answer/10488752?hl=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

3 participants