Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to configure the rbf-interpolation #10

Open
arvedes opened this issue May 9, 2022 · 3 comments
Open

Provide an option to configure the rbf-interpolation #10

arvedes opened this issue May 9, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@arvedes
Copy link
Contributor

arvedes commented May 9, 2022

The default rbf-iterpolation

rbf_interp = Rbf(coords_x, coords_y, res)
currently used in the adapter may lead to issues for some cases, see e.g. https://precice.discourse.group/t/problem-with-rbf-interpolation-in-the-fenics-x-adapter/1037. We should provide an option to configure the rbf parameters.

@arvedes arvedes added the enhancement New feature or request label May 9, 2022
@precice-bot
Copy link

This issue has been mentioned on preCICE Forum on Discourse. There might be relevant details there:

https://precice.discourse.group/t/problem-with-rbf-interpolation-in-the-fenics-x-adapter/1037/7

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented May 11, 2022

Another idea: There is actually PyRBF, which also comes from the "preCICE bubble". If we use this package, we could make sure that the RBF interpolation performed in the adapter is consistent with the interpolation performed in preCICE. I'll try to evaluate this option with @IshaanDesai and @KyleDavisSA.

Note: The most recent and actively maintained version is Kyle's fork: https://github.com/KyleDavisSA/PyRBF

@IshaanDesai
Copy link
Member

Using PyRBF is a really good idea here, as it would lead to having a choice between several integration schemes. The major work package I see here is to convert PyRBF into a library if that is not already the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants