From 3e0c70d0189f4fcc03d2a88bf6ec7315b0a0d28a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Fri, 29 Sep 2023 12:34:04 -0400 Subject: [PATCH] chore(misc): Spelling (#25456) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/CODEOWNERS | 2 +- .github/ISSUE_TEMPLATE/sip.md | 2 +- .github/workflows/chromatic-master.yml | 2 +- .github/workflows/codecov.sh | 4 +- .github/workflows/prefer-typescript.yml | 4 +- CHANGELOG.md | 66 +++++++++---------- CONTRIBUTING.md | 26 ++++---- RELEASING/README.md | 4 +- RELEASING/release-notes-2-0/README.md | 4 +- RELEASING/release-notes-2-0/changelog.md | 12 ++-- UPDATING.md | 12 ++-- .../examples-init.sh | 2 +- scripts/generate_frontend_ts_tasklist.js | 4 +- superset-embedded-sdk/CONTRIBUTING.md | 2 +- 14 files changed, 73 insertions(+), 73 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a8c00eb7d8e73..d49c1e4a86c3b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -24,6 +24,6 @@ /superset-frontend/cypress-base/ @jinghua-qa @geido @eschutho @rusackas @betodealmeida -# Notify PMC members of changes to Github Actions +# Notify PMC members of changes to GitHub Actions /.github/ @villebro @geido @eschutho @rusackas @betodealmeida @nytai @mistercrunch @craig-rueda @john-bodley @kgabryje diff --git a/.github/ISSUE_TEMPLATE/sip.md b/.github/ISSUE_TEMPLATE/sip.md index c01e7b1ab7d77..d4ecc6083a5bf 100644 --- a/.github/ISSUE_TEMPLATE/sip.md +++ b/.github/ISSUE_TEMPLATE/sip.md @@ -3,7 +3,7 @@ name: SIP about: "Superset Improvement Proposal. See [here](https://github.com/apache/superset/issues/5602) for details." labels: sip title: "[SIP] Your Title Here (do not add SIP number)" -asignees: "apache/superset-committers" +assignees: "apache/superset-committers" --- *Please make sure you are familiar with the SIP process documented* diff --git a/.github/workflows/chromatic-master.yml b/.github/workflows/chromatic-master.yml index 11e07e6c5ab3e..efdbfec2f65bb 100644 --- a/.github/workflows/chromatic-master.yml +++ b/.github/workflows/chromatic-master.yml @@ -1,5 +1,5 @@ # .github/workflows/chromatic.yml -# seee https://www.chromatic.com/docs/github-actions +# see https://www.chromatic.com/docs/github-actions # # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distributed with diff --git a/.github/workflows/codecov.sh b/.github/workflows/codecov.sh index fa80d246a38ca..75c13b7643af2 100755 --- a/.github/workflows/codecov.sh +++ b/.github/workflows/codecov.sh @@ -174,7 +174,7 @@ cat << EOF -c Move discovered coverage reports to the trash -z FILE Upload specified file directly to Codecov and bypass all report generation. - This is inteded to be used only with a pre-formatted Codecov report and is not + This is intended to be used only with a pre-formatted Codecov report and is not expected to work under any other circumstances. -Z Exit with 1 if not successful. Default will Exit with 0 @@ -1152,7 +1152,7 @@ fi if [ "$ft_search" = "1" ]; then - # detect bower comoponents location + # detect bower components location bower_components="bower_components" bower_rc=$(cd "$git_root" && cat .bowerrc 2>/dev/null || echo "") if [ "$bower_rc" != "" ]; diff --git a/.github/workflows/prefer-typescript.yml b/.github/workflows/prefer-typescript.yml index 49ab90fb6f92a..a1e75c73d422a 100644 --- a/.github/workflows/prefer-typescript.yml +++ b/.github/workflows/prefer-typescript.yml @@ -1,4 +1,4 @@ -name: Prefer Typescript +name: Prefer TypeScript on: push: @@ -9,7 +9,7 @@ on: jobs: prefer_typescript: if: github.ref == 'ref/heads/master' && github.event_name == 'pull_request' - name: Prefer Typescript + name: Prefer TypeScript runs-on: ubuntu-latest permissions: contents: read diff --git a/CHANGELOG.md b/CHANGELOG.md index 976cacced938b..c6ea7cb852953 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -63,7 +63,7 @@ under the License. - [#24197](https://github.com/apache/superset/pull/24197) chore(pre-commit): Add pyupgrade and pycln hooks (@john-bodley) - [#24127](https://github.com/apache/superset/pull/24127) chore: Embrace the walrus operator (@john-bodley) - [#24020](https://github.com/apache/superset/pull/24020) feat: Cross filters scoping (@kgabryje) -- [#23942](https://github.com/apache/superset/pull/23942) fix: update migration chart_ds_constraint to have seperate batch op (@hughhhh) +- [#23942](https://github.com/apache/superset/pull/23942) fix: update migration chart_ds_constraint to have separate batch op (@hughhhh) - [#23925](https://github.com/apache/superset/pull/23925) fix(migration): add log for values unseen in `Slice.datasource_type` (@hughhhh) - [#23614](https://github.com/apache/superset/pull/23614) chore: add check constraint to restrict `Slice` models datasource_type != "table" (@hughhhh) - [#23650](https://github.com/apache/superset/pull/23650) fix(migration): Only attempt to drop types if they exist (@jfrag1) @@ -96,7 +96,7 @@ under the License. - [#24345](https://github.com/apache/superset/pull/24345) feat: Convert ENABLE_BROAD_ACTIVITY_ACCESS and MENU_HIDE_USER_INFO into feature flags (@michael-s-molina) - [#23943](https://github.com/apache/superset/pull/23943) feat: Removes the preset-chart-xy plugin (@michael-s-molina) - [#23933](https://github.com/apache/superset/pull/23933) feat: Removes the Multiple Line Charts (@michael-s-molina) -- [#24237](https://github.com/apache/superset/pull/24237) feat: support complex types and use get_columns implementation of starrrocks python client (@miomiocat) +- [#24237](https://github.com/apache/superset/pull/24237) feat: support complex types and use get_columns implementation of starrocks python client (@miomiocat) - [#24205](https://github.com/apache/superset/pull/24205) feat(sqllab): SQLEditor Extension (@Antonio-RiveroMartnez) - [#24232](https://github.com/apache/superset/pull/24232) feat(flags): enabling and deprecating a few feature flags (@rusackas) - [#24191](https://github.com/apache/superset/pull/24191) feat: extension hook for DB delete (@betodealmeida) @@ -167,7 +167,7 @@ under the License. - [#23138](https://github.com/apache/superset/pull/23138) feat: Cross Filters in FilterBar (@geido) - [#23099](https://github.com/apache/superset/pull/23099) feat(ssh_tunnel): Import/Export Databases with SSHTunnel credentials (@Antonio-RiveroMartnez) - [#23141](https://github.com/apache/superset/pull/23141) feat(dashboard): Add cross filter from context menu (@kgabryje) -- [#22886](https://github.com/apache/superset/pull/22886) feat: Enable cross fitlers in WorldMap and Graph charts (@kgabryje) +- [#22886](https://github.com/apache/superset/pull/22886) feat: Enable cross filters in WorldMap and Graph charts (@kgabryje) - [#23143](https://github.com/apache/superset/pull/23143) feat: return UUID on database creation (@betodealmeida) - [#20876](https://github.com/apache/superset/pull/20876) feat: Frontend tagging (@cccs-RyanK) @@ -279,7 +279,7 @@ under the License. - [#24567](https://github.com/apache/superset/pull/24567) fix: remove underscore from builtin_time_grains label (@cnabro) - [#24608](https://github.com/apache/superset/pull/24608) fix: Incorrect dependency between filters related feature flags (@michael-s-molina) - [#24612](https://github.com/apache/superset/pull/24612) fix(report): edit without custom width (@betodealmeida) -- [#24552](https://github.com/apache/superset/pull/24552) fix(ssh): Editting Database w/ SSH Tunneling (@hughhhh) +- [#24552](https://github.com/apache/superset/pull/24552) fix(ssh): Editing Database w/ SSH Tunneling (@hughhhh) - [#24556](https://github.com/apache/superset/pull/24556) fix: set max version for pyocient (@jwilliams-ocient) - [#24129](https://github.com/apache/superset/pull/24129) fix: Bump prophet, re-enable tests, and remedy column eligibility logic (@john-bodley) - [#24593](https://github.com/apache/superset/pull/24593) fix: Clicking on a tag in the dashboard and charts lists does not work (@michael-s-molina) @@ -333,7 +333,7 @@ under the License. - [#24279](https://github.com/apache/superset/pull/24279) fix(migrations): Fixing cross filter migration (@craig-rueda) - [#24256](https://github.com/apache/superset/pull/24256) fix: enable strong session protection by default (@dpgaspar) - [#23562](https://github.com/apache/superset/pull/23562) fix(docs): Update databricks.mdx with correct pip package name (@amosdoublec) -- [#24217](https://github.com/apache/superset/pull/24217) fix: Typescript warnings when importing types (@michael-s-molina) +- [#24217](https://github.com/apache/superset/pull/24217) fix: TypeScript warnings when importing types (@michael-s-molina) - [#24222](https://github.com/apache/superset/pull/24222) fix(helm): Use correct default hostnames for postgres and redis (@NickLarsenNZ) - [#24242](https://github.com/apache/superset/pull/24242) fix(dataset-api): allow undefined schema in post (@villebro) - [#24207](https://github.com/apache/superset/pull/24207) fix: removing problematic "formattable" tag (@rusackas) @@ -367,7 +367,7 @@ under the License. - [#23892](https://github.com/apache/superset/pull/23892) fix(sql-editor): Fix run stop button color to improve usability (@curious86) - [#23909](https://github.com/apache/superset/pull/23909) fix: remove feature flag for tags on Dashboard API for `Tags` (@hughhhh) - [#23881](https://github.com/apache/superset/pull/23881) fix(native-filters): Address spelling mistakes (@john-bodley) -- [#23778](https://github.com/apache/superset/pull/23778) fix(chart): scrollbar keep flusing on and off (@justinpark) +- [#23778](https://github.com/apache/superset/pull/23778) fix(chart): scrollbar keep flushing on and off (@justinpark) - [#23868](https://github.com/apache/superset/pull/23868) fix: move dynamic schema out of base Postgres class (@hughhhh) - [#23702](https://github.com/apache/superset/pull/23702) fix: npm run dev-server error resolved (@Abhishek-kumar-samsung) - [#23872](https://github.com/apache/superset/pull/23872) fix(dremio): query with alias (@betodealmeida) @@ -538,7 +538,7 @@ under the License. - [#24504](https://github.com/apache/superset/pull/24504) build(docker): simplification of assembly to facilitate further support (@alekseyolg) - [#24503](https://github.com/apache/superset/pull/24503) chore: update ansi-regex (@hughhhh) - [#24489](https://github.com/apache/superset/pull/24489) chore(sqllab): add extra_json on tabstate (@justinpark) -- [#24497](https://github.com/apache/superset/pull/24497) build(docker): pin the underlying debain base image (@boenshao) +- [#24497](https://github.com/apache/superset/pull/24497) build(docker): pin the underlying debian base image (@boenshao) - [#24371](https://github.com/apache/superset/pull/24371) chore(sqllab): Remove table metadata from state (@justinpark) - [#24443](https://github.com/apache/superset/pull/24443) build(deps-dev): bump eslint from 8.42.0 to 8.43.0 in /superset-websocket (@dependabot[bot]) - [#24454](https://github.com/apache/superset/pull/24454) build(deps-dev): bump @typescript-eslint/eslint-plugin from 5.59.11 to 5.60.0 in /superset-websocket (@dependabot[bot]) @@ -839,7 +839,7 @@ under the License. - [#23582](https://github.com/apache/superset/pull/23582) fix(dash import): Ensure old datasource ids are not referenced in imported charts (@jfrag1) - [#23506](https://github.com/apache/superset/pull/23506) fix(generic-x-axis): skip initial time filter for legacy charts (@villebro) - [#23507](https://github.com/apache/superset/pull/23507) fix(legacy-plugin-chart-heatmap): fix adhoc column tooltip (@villebro) -- [#23441](https://github.com/apache/superset/pull/23441) fix(chart): non existent time grain no longer breaks the application (@rdubois) +- [#23441](https://github.com/apache/superset/pull/23441) fix(chart): nonexistent time grain no longer breaks the application (@rdubois) - [#23393](https://github.com/apache/superset/pull/23393) fix(Pivot Table v2): resolved full width issue (@AkashBoora) - [#22851](https://github.com/apache/superset/pull/22851) fix: Validate jinja rendered query (@geido) @@ -955,7 +955,7 @@ under the License. - [#22031](https://github.com/apache/superset/pull/22031) feat: Adds more customization properties to DropdownContainer (@michael-s-molina) - [#22004](https://github.com/apache/superset/pull/22004) feat(dashboard): Support changing filter bar location (@kgabryje) - [#21974](https://github.com/apache/superset/pull/21974) feat: Adds the DropdownContainer component (@michael-s-molina) -- [#21767](https://github.com/apache/superset/pull/21767) feat: support mulitple temporal filters in AdhocFilter and move the Time Section away (@zhaoyongjie) +- [#21767](https://github.com/apache/superset/pull/21767) feat: support multiple temporal filters in AdhocFilter and move the Time Section away (@zhaoyongjie) - [#21955](https://github.com/apache/superset/pull/21955) feat: Selectable dropdown triggered by icon component (@geido) - [#21931](https://github.com/apache/superset/pull/21931) feat(reports): execute as other than selenium user (@villebro) - [#21806](https://github.com/apache/superset/pull/21806) feat(helm): Support for flower and websocket containers (@Yann-J) @@ -1032,7 +1032,7 @@ under the License. - [#20891](https://github.com/apache/superset/pull/20891) feat: Adds drill to detail context menu for ECharts visualizations (@michael-s-molina) - [#20567](https://github.com/apache/superset/pull/20567) feat(helm): add liveness and readiness for deployment webserver (@jplanckeel) - [#20990](https://github.com/apache/superset/pull/20990) feat: per-db add metrics (@betodealmeida) -- [#21008](https://github.com/apache/superset/pull/21008) feat: supports mulitple filters in samples endpoint (@zhaoyongjie) +- [#21008](https://github.com/apache/superset/pull/21008) feat: supports multiple filters in samples endpoint (@zhaoyongjie) - [#20945](https://github.com/apache/superset/pull/20945) feat: useReducer for dataset creation (@AAfghahi) - [#20835](https://github.com/apache/superset/pull/20835) feat: add 'dashboard.nav.right' extension to registry (@samtfm) - [#20416](https://github.com/apache/superset/pull/20416) feat(embedded-SDK): enable CSV download (@lilykuang) @@ -1065,7 +1065,7 @@ under the License. - [#20017](https://github.com/apache/superset/pull/20017) feat: hack db connection modal ctabtns (@pkdotson) - [#20586](https://github.com/apache/superset/pull/20586) feat: drop missing columns control (@zhaoyongjie) - [#19520](https://github.com/apache/superset/pull/19520) feat(deck.gl): add color range for deck.gl 3D chart (@stephenLYZ) -- [#20512](https://github.com/apache/superset/pull/20512) feat(sql lab): Save Dataset Modal Autocomplete should display list when overwritting (@Antonio-RiveroMartnez) +- [#20512](https://github.com/apache/superset/pull/20512) feat(sql lab): Save Dataset Modal Autocomplete should display list when overwriting (@Antonio-RiveroMartnez) - [#20575](https://github.com/apache/superset/pull/20575) feat: add extension point to the top of welcome page (@lilykuang) - [#20579](https://github.com/apache/superset/pull/20579) feat: apply standardized form data to deckgl (@zhaoyongjie) - [#20514](https://github.com/apache/superset/pull/20514) feat: add extension point to the right side of the menu bar (@samtfm) @@ -1158,7 +1158,7 @@ under the License. - [#22671](https://github.com/apache/superset/pull/22671) fix: remove whitespace from http_path for databricks (@eschutho) - [#22716](https://github.com/apache/superset/pull/22716) fix(helm): remove config overrides for CSRF (@reidab) - [#22693](https://github.com/apache/superset/pull/22693) fix(explore): Restore missing dataset states (@codyml) -- [#22720](https://github.com/apache/superset/pull/22720) fix: bootstraping frontend (@cdreier) +- [#22720](https://github.com/apache/superset/pull/22720) fix: bootstrapping frontend (@cdreier) - [#22709](https://github.com/apache/superset/pull/22709) fix: Spacing in alert modal (@lyndsiWilliams) - [#22688](https://github.com/apache/superset/pull/22688) fix: alert modal bug fix (@AAfghahi) - [#22462](https://github.com/apache/superset/pull/22462) fix(embed): fix server error due to breaking change on flask-login (@Usiel) @@ -1434,7 +1434,7 @@ under the License. - [#21025](https://github.com/apache/superset/pull/21025) fix: unable to show view as table modal (@zhaoyongjie) - [#21030](https://github.com/apache/superset/pull/21030) fix: making crossFilter.chartsInScope optional (@rusackas) - [#20970](https://github.com/apache/superset/pull/20970) fix: forwardRef warnings in selects (@michael-s-molina) -- [#21017](https://github.com/apache/superset/pull/21017) fix(plugin-echart-timeseries): legend trancated on show extra controls (@justinpark) +- [#21017](https://github.com/apache/superset/pull/21017) fix(plugin-echart-timeseries): legend truncated on show extra controls (@justinpark) - [#21016](https://github.com/apache/superset/pull/21016) fix(sqllab): result set min-height (@ktmud) - [#20999](https://github.com/apache/superset/pull/20999) fix: quick fix to rows returned in results (@AAfghahi) - [#20965](https://github.com/apache/superset/pull/20965) fix: save dataset and repopulate state (@eschutho) @@ -1767,7 +1767,7 @@ under the License. - [#22068](https://github.com/apache/superset/pull/22068) test: Fix act errors in DndColumnSelectControl tests (@corbinrobb) - [#22048](https://github.com/apache/superset/pull/22048) test: Fix act errors in DndMetricSelect test (@lyndsiWilliams) - [#22041](https://github.com/apache/superset/pull/22041) chore: Adds RTL tests to DropdownContainer (@michael-s-molina) -- [#21954](https://github.com/apache/superset/pull/21954) build: Mutli-stage build and slim image for websocket container (@Yann-J) +- [#21954](https://github.com/apache/superset/pull/21954) build: Multi-stage build and slim image for websocket container (@Yann-J) - [#22032](https://github.com/apache/superset/pull/22032) chore(dataset): enable reload for schema and table (@justinpark) - [#22015](https://github.com/apache/superset/pull/22015) refactor: Feature flags getter (@zhaoyongjie) - [#22002](https://github.com/apache/superset/pull/22002) refactor: clean up codes (@zhaoyongjie) @@ -1836,7 +1836,7 @@ under the License. - [#21566](https://github.com/apache/superset/pull/21566) docs: Turkey map already added (@rizacavus) - [#21565](https://github.com/apache/superset/pull/21565) chore(deps): bump moment-timezone from 0.5.33 to 0.5.37 in /superset-frontend (@dependabot[bot]) - [#21553](https://github.com/apache/superset/pull/21553) chore: Remove chromatic job per PR as it has errors (@eric-briscoe) -- [#21496](https://github.com/apache/superset/pull/21496) refactor: Rewrites ColorSchemeControl with Typescript (@michael-s-molina) +- [#21496](https://github.com/apache/superset/pull/21496) refactor: Rewrites ColorSchemeControl with TypeScript (@michael-s-molina) - [#21320](https://github.com/apache/superset/pull/21320) chore: refactor SqlEditor to functional component (@EugeneTorap) - [#21510](https://github.com/apache/superset/pull/21510) refactor: refine timestamp expr function (@zhaoyongjie) - [#21524](https://github.com/apache/superset/pull/21524) chore: should return if get a exception in Dashboard edit modal (@zhaoyongjie) @@ -1956,7 +1956,7 @@ under the License. - [#20612](https://github.com/apache/superset/pull/20612) chore(explore): update Explore icons and icon colors (@codyml) - [#20915](https://github.com/apache/superset/pull/20915) chore(test): Unskip Cypress test (@codyml) - [#20884](https://github.com/apache/superset/pull/20884) other(mypy): Enable warn_unused_ignores (@john-bodley) -- [#20690](https://github.com/apache/superset/pull/20690) chore: Remove unecessary code from async and sync select components (@cccs-RyanK) +- [#20690](https://github.com/apache/superset/pull/20690) chore: Remove unnecessary code from async and sync select components (@cccs-RyanK) - [#20669](https://github.com/apache/superset/pull/20669) chore: adding Bazaar Technologies to Superset Users (@umair-abro) - [#20786](https://github.com/apache/superset/pull/20786) chore(deps): bump terser from 5.9.0 to 5.14.2 in /docs (@dependabot[bot]) - [#20810](https://github.com/apache/superset/pull/20810) refactor: Improve performance regression introduced in #20473 (@john-bodley) @@ -2132,7 +2132,7 @@ under the License. - [#19898](https://github.com/apache/superset/pull/19898) feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed (@diegomedina248) - [#16493](https://github.com/apache/superset/pull/16493) feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 (@stephenLYZ) - [#19855](https://github.com/apache/superset/pull/19855) feat(explore): Frontend implementation of dataset creation from infobox (@lyndsiWilliams) -- [#20165](https://github.com/apache/superset/pull/20165) feat: add modfied col and timezone info to schedule col (@pkdotson) +- [#20165](https://github.com/apache/superset/pull/20165) feat: add modified col and timezone info to schedule col (@pkdotson) - [#20144](https://github.com/apache/superset/pull/20144) feat: showing results pane in dashboard (@zhaoyongjie) - [#20242](https://github.com/apache/superset/pull/20242) feat: derived metrics use different line style (@zhaoyongjie) - [#20010](https://github.com/apache/superset/pull/20010) feat: standardized form_data (@zhaoyongjie) @@ -2188,7 +2188,7 @@ under the License. - [#19558](https://github.com/apache/superset/pull/19558) feat(explore): Redesign of Run/Save buttons (@kgabryje) - [#19650](https://github.com/apache/superset/pull/19650) feat(embedded): API get embedded dashboard config by uuid (@lilykuang) - [#19310](https://github.com/apache/superset/pull/19310) feat(CRUD): add new empty state (@stephenLYZ) -- [#19622](https://github.com/apache/superset/pull/19622) feat(plugin-chart-echarts): add aggregate total for the Pie/Donuct chart (@stephenLYZ) +- [#19622](https://github.com/apache/superset/pull/19622) feat(plugin-chart-echarts): add aggregate total for the Pie/Donut chart (@stephenLYZ) - [#19314](https://github.com/apache/superset/pull/19314) feat: Move Database Import option into DB Connection modal (@lyndsiWilliams) - [#19434](https://github.com/apache/superset/pull/19434) feat: deprecate old API and create new API for dashes created by me (@dpgaspar) - [#19482](https://github.com/apache/superset/pull/19482) feat: add success toast to alerts and reports (@pkdotson) @@ -2270,7 +2270,7 @@ under the License. - [#20204](https://github.com/apache/superset/pull/20204) fix: Fixes issue where results panel height was incorrect [sc-49045] (@eric-briscoe) - [#20235](https://github.com/apache/superset/pull/20235) fix: Box Plot Chart throws an error when the average (AVG) / SUM is being calculated on the Metrics (@diegomedina248) - [#20088](https://github.com/apache/superset/pull/20088) fix: datatype tracking issue on virtual dataset (@codemaster08240328) -- [#20220](https://github.com/apache/superset/pull/20220) fix: dashbaord unable to refresh (@zhaoyongjie) +- [#20220](https://github.com/apache/superset/pull/20220) fix: dashboard unable to refresh (@zhaoyongjie) - [#20228](https://github.com/apache/superset/pull/20228) fix: failed samples should throw exception (@zhaoyongjie) - [#20203](https://github.com/apache/superset/pull/20203) fix: move columns to datasource object for bootstrap data (@hughhhh) - [#20151](https://github.com/apache/superset/pull/20151) fix(csv): Ensure df_to_escaped_csv does not coerce integer columns to float (@john-bodley) @@ -2280,7 +2280,7 @@ under the License. - [#20206](https://github.com/apache/superset/pull/20206) fix(sql lab): SQL Lab Compile Query Delay (@diegomedina248) - [#20201](https://github.com/apache/superset/pull/20201) fix: unable to set destroyOnClose on ModalTrigger (@zhaoyongjie) - [#20186](https://github.com/apache/superset/pull/20186) fix(db): make to allow to show/hide the password when only creating (@prosdev0107) -- [#20127](https://github.com/apache/superset/pull/20127) fix(database): retrival of tables and views from schema for exasol backend (@Nicoretti) +- [#20127](https://github.com/apache/superset/pull/20127) fix(database): retrieval of tables and views from schema for exasol backend (@Nicoretti) - [#19899](https://github.com/apache/superset/pull/19899) fix: always create parameter json field (@pkdotson) - [#20173](https://github.com/apache/superset/pull/20173) fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied (@diegomedina248) - [#20086](https://github.com/apache/superset/pull/20086) fix(css): transparent linear gradient not working in safari (@stephenLYZ) @@ -2387,7 +2387,7 @@ under the License. - [#19570](https://github.com/apache/superset/pull/19570) fix: sqloxide optional (@betodealmeida) - [#19397](https://github.com/apache/superset/pull/19397) fix: weight tooltip issue (@codemaster08240328) - [#19313](https://github.com/apache/superset/pull/19313) fix(sql lab): increase the size of the action icons in the history tab (@diegomedina248) -- [#19039](https://github.com/apache/superset/pull/19039) fix(explore): clean data when hidding control (@stephenLYZ) +- [#19039](https://github.com/apache/superset/pull/19039) fix(explore): clean data when hiding control (@stephenLYZ) - [#19444](https://github.com/apache/superset/pull/19444) fix: Error Message is cut off in alerts & reports log page (@codemaster08240328) - [#19312](https://github.com/apache/superset/pull/19312) fix: adaptive formatting typo in explore dropdowns (@diegomedina248) - [#19534](https://github.com/apache/superset/pull/19534) fix(explore): Chart header icon paddings (@kgabryje) @@ -2556,7 +2556,7 @@ under the License. - [#19486](https://github.com/apache/superset/pull/19486) refactor: Removes the CSS files from the Treemap plugin (@michael-s-molina) - [#19488](https://github.com/apache/superset/pull/19488) refactor: Removes the CSS files from the Sunburst plugin (@michael-s-molina) - [#19490](https://github.com/apache/superset/pull/19490) chore: Add theme color to ParallelCoordinates (@geido) -- [#19442](https://github.com/apache/superset/pull/19442) chore: Remove FilterbaleTableStyles.less (@geido) +- [#19442](https://github.com/apache/superset/pull/19442) chore: Remove FilterableTableStyles.less (@geido) - [#19441](https://github.com/apache/superset/pull/19441) chore: Remove StyledQueryButton.less (@geido) - [#19473](https://github.com/apache/superset/pull/19473) refactor: Removes the CSS files from the Rose plugin (@michael-s-molina) - [#19466](https://github.com/apache/superset/pull/19466) chore: Removes hard-coded colors from legacy-plugin-chart-world-map (@michael-s-molina) @@ -2827,7 +2827,7 @@ under the License. - [#19716](https://github.com/apache/superset/pull/19716) fix: drop the first level of MultiIndex (@zhaoyongjie) - [#19688](https://github.com/apache/superset/pull/19688) fix(dashboard): Fix BigNumber causing dashboard to crash when overflowing (@kgabryje) - [#19664](https://github.com/apache/superset/pull/19664) fix(sql-lab): do not replace undefined schema with empty object (@villebro) -- [#19659](https://github.com/apache/superset/pull/19659) fix: time comparision (@zhaoyongjie) +- [#19659](https://github.com/apache/superset/pull/19659) fix: time comparison (@zhaoyongjie) - [#19553](https://github.com/apache/superset/pull/19553) fix(dataset): handle missing python_type gracefully (@villebro) - [#19612](https://github.com/apache/superset/pull/19612) fix(select): render when empty multiselect (@villebro) - [#19565](https://github.com/apache/superset/pull/19565) fix(sqla): apply jinja to metrics (@villebro) @@ -2856,7 +2856,7 @@ under the License. - [#19341](https://github.com/apache/superset/pull/19341) fix: Null values on Explore filter (@michael-s-molina) - [#19338](https://github.com/apache/superset/pull/19338) fix(docs): spelling (@ndbu) - [#19339](https://github.com/apache/superset/pull/19339) fix(embedded): download chart as image (@lilykuang) -- [#19327](https://github.com/apache/superset/pull/19327) fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail (@kgabryje) +- [#19327](https://github.com/apache/superset/pull/19327) fix(dashboard): Chart stuck in loading state when datasets request and chart request fail (@kgabryje) - [#19316](https://github.com/apache/superset/pull/19316) fix(explore): make to convert null to N/A in view results (@prosdev0107) - [#19326](https://github.com/apache/superset/pull/19326) fix: regression on Select component when handling null values (@diegomedina248) - [#18741](https://github.com/apache/superset/pull/18741) fix(dashboard): fix default filter bar visibility + add docs (@villebro) @@ -2887,7 +2887,7 @@ under the License. - [#19080](https://github.com/apache/superset/pull/19080) fix(dashboard-edge-cutting): make to be not cut without Filter (@prosdev0107) - [#19110](https://github.com/apache/superset/pull/19110) fix: cache key with guest token rls (@lilykuang) - [#19095](https://github.com/apache/superset/pull/19095) fix(dashboard): Empty states overflowing small chart containers (@kgabryje) -- [#18947](https://github.com/apache/superset/pull/18947) fix(plugin-chart-echarts): make to allow the custome of x & y axis title margin i… (@prosdev0107) +- [#18947](https://github.com/apache/superset/pull/18947) fix(plugin-chart-echarts): make to allow the customization of x & y axis title margin i… (@prosdev0107) - [#19088](https://github.com/apache/superset/pull/19088) fix(dashboard): import handle missing excluded charts (@villebro) - [#19072](https://github.com/apache/superset/pull/19072) fix: Show Totals error with sort and group by together (@codemaster08240328) - [#19037](https://github.com/apache/superset/pull/19037) fix: Database import error with a new field (@codemaster08240328) @@ -2904,7 +2904,7 @@ under the License. - [#19052](https://github.com/apache/superset/pull/19052) fix: add previous line hotkey to SQL Lab for macOS (@diegomedina248) - [#18690](https://github.com/apache/superset/pull/18690) fix: Update time grain expressions for Spark >= 3.x (@thomasdesr) - [#19048](https://github.com/apache/superset/pull/19048) fix: remove unnecessary divider (@pkdotson) -- [#19059](https://github.com/apache/superset/pull/19059) fix(deck.gl): make Deck.gl Javascript tooltip generator works correctly (@chanyou0311) +- [#19059](https://github.com/apache/superset/pull/19059) fix(deck.gl): make Deck.gl JavaScript tooltip generator works correctly (@chanyou0311) - [#19044](https://github.com/apache/superset/pull/19044) fix: improve cypress flakiness (@etr2460) - [#19043](https://github.com/apache/superset/pull/19043) fix(big-number): Big Number with Trendline Chart is not working if Time Grain is set to Month (@stephenLYZ) - [#19040](https://github.com/apache/superset/pull/19040) fix(docs): update impala.mdx with correct product name (@DLT1412) @@ -2912,7 +2912,7 @@ under the License. - [#18877](https://github.com/apache/superset/pull/18877) fix(nested-tab-available): make the another tabs into one tabs available (@prosdev0107) - [#18960](https://github.com/apache/superset/pull/18960) fix(chart): deprecate persisting url_params (@villebro) - [#18973](https://github.com/apache/superset/pull/18973) fix(packages): Fixing users packages (@craig-rueda) -- [#18892](https://github.com/apache/superset/pull/18892) fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away (@prosdev0107) +- [#18892](https://github.com/apache/superset/pull/18892) fix(tooltip-not-disappeared): make the tooltip disappear when mouse away (@prosdev0107) - [#18982](https://github.com/apache/superset/pull/18982) fix(external-link): change the external link in creating chart dashboard (@prosdev0107) - [#18963](https://github.com/apache/superset/pull/18963) fix(native-filters): Default value not shown in native filters (@kgabryje) - [#18958](https://github.com/apache/superset/pull/18958) fix(plugin-chart-echarts): fix customize margin (@stephenLYZ) @@ -2964,7 +2964,7 @@ under the License. - [#18628](https://github.com/apache/superset/pull/18628) fix: check embedded feature flag in request loader (@lilykuang) - [#18562](https://github.com/apache/superset/pull/18562) fix: user UUIDs on export for Native Filter Configuration (@hughhhh) - [#18619](https://github.com/apache/superset/pull/18619) fix(helm): Fix support for ingress.ingressClassName (@ad-m) -- [#18609](https://github.com/apache/superset/pull/18609) fix: change database database selector (@pkdotson) +- [#18609](https://github.com/apache/superset/pull/18609) fix: change database selector (@pkdotson) - [#18601](https://github.com/apache/superset/pull/18601) fix(jest): add superset-frontend to testRegex (@villebro) - [#18564](https://github.com/apache/superset/pull/18564) fix: sqllab schema select error msg (@pkdotson) - [#18579](https://github.com/apache/superset/pull/18579) fix(sqla): avoid unnecessary groupby in samples request (@villebro) @@ -2981,7 +2981,7 @@ under the License. - [#18217](https://github.com/apache/superset/pull/18217) fix(plugin-chart-echarts): use verbose x-axis name when defined (@villebro) - [#18216](https://github.com/apache/superset/pull/18216) fix(explore): Pie chart label formatting when series is temporal (@kgabryje) - [#17881](https://github.com/apache/superset/pull/17881) fix(sql): unable to filter text with quotes (@stephenLYZ) -- [#18205](https://github.com/apache/superset/pull/18205) fix(tests): Remove walrus operator for Python 3.7 compatiblity (@ad-m) +- [#18205](https://github.com/apache/superset/pull/18205) fix(tests): Remove walrus operator for Python 3.7 compatibility (@ad-m) - [#18145](https://github.com/apache/superset/pull/18145) fix(native-filters): values is not sorted when setting sort option (@stephenLYZ) - [#18174](https://github.com/apache/superset/pull/18174) fix(helm): allows extra top-level properties (@ad-m) - [#18180](https://github.com/apache/superset/pull/18180) fix: Default values getting cleared in native filters form (@geido) @@ -3216,7 +3216,7 @@ under the License. - [#18955](https://github.com/apache/superset/pull/18955) docs: fix sql templating typos (@garyng) - [#18931](https://github.com/apache/superset/pull/18931) chore: Moves components out of the commons folder (@michael-s-molina) - [#18915](https://github.com/apache/superset/pull/18915) test(Native Filter): User can create parent filters using "Filter is hierarchical (@jinghua-qa) -- [#18811](https://github.com/apache/superset/pull/18811) chore: add intersect method from backend to fontend for upload extensions (@pkdotson) +- [#18811](https://github.com/apache/superset/pull/18811) chore: add intersect method from backend to frontend for upload extensions (@pkdotson) - [#18935](https://github.com/apache/superset/pull/18935) chore: update `UPDATING.md` re: SIP-68 (@betodealmeida) - [#18866](https://github.com/apache/superset/pull/18866) refactor(ImportModelsCommand): clean code, extract logic into methods (@michael-hoffman-26) - [#18850](https://github.com/apache/superset/pull/18850) test(native filter): add new native filter test for time column filter (@jinghua-qa) @@ -3288,7 +3288,7 @@ under the License. - [#18254](https://github.com/apache/superset/pull/18254) docs(i18n): make translation guide more explicit (@villebro) - [#18231](https://github.com/apache/superset/pull/18231) chore: add ci for docs-v2 (@ad-m) - [#18559](https://github.com/apache/superset/pull/18559) chore: Update Docusaurus dependencies (@geido) -- [#18229](https://github.com/apache/superset/pull/18229) chore: Reference Github code in Docusaurus (@geido) +- [#18229](https://github.com/apache/superset/pull/18229) chore: Reference GitHub code in Docusaurus (@geido) - [#18251](https://github.com/apache/superset/pull/18251) chore(tests): migrate mssql tests to pytest (@villebro) - [#18188](https://github.com/apache/superset/pull/18188) refactor: upgrade ControlHeader to TSX & FC and add storybook (@ad-m) - [#18230](https://github.com/apache/superset/pull/18230) chore: Docusaurus throw on broken links (@geido) @@ -3340,7 +3340,7 @@ under the License. - [#17962](https://github.com/apache/superset/pull/17962) chore(deps): bump urijs from 1.19.6 to 1.19.7 in /superset-frontend (@dependabot[bot]) - [#17942](https://github.com/apache/superset/pull/17942) chore: Fix 'button' misspelling in list_with_checkboxes (@acrks) - [#17860](https://github.com/apache/superset/pull/17860) chore: remove unused eslintrc (@zhaoyongjie) -- [#17909](https://github.com/apache/superset/pull/17909) refactor(storybok): upgrade to webpack5 in storybook of plugins (@zhaoyongjie) +- [#17909](https://github.com/apache/superset/pull/17909) refactor(storybook): upgrade to webpack5 in storybook of plugins (@zhaoyongjie) - [#17924](https://github.com/apache/superset/pull/17924) chore: fix misspelling of button (@DavidWoolner) - [#17782](https://github.com/apache/superset/pull/17782) ci: make presto hive tests to cover only chartData and sqljson (@amitmiran137) - [#17717](https://github.com/apache/superset/pull/17717) chore: Fix UPDATING.md (@john-bodley) @@ -3351,7 +3351,7 @@ under the License. - [#17811](https://github.com/apache/superset/pull/17811) other: Add Helm chart option for configOverrides through file (@dd-willgan) - [#17828](https://github.com/apache/superset/pull/17828) chore: add lerna version (@zhaoyongjie) - [#17827](https://github.com/apache/superset/pull/17827) refactor(monorepo): migrate plugins release workflow (@zhaoyongjie) -- [#17754](https://github.com/apache/superset/pull/17754) docs: update contribuing docs (@zhaoyongjie) +- [#17754](https://github.com/apache/superset/pull/17754) docs: update contributing docs (@zhaoyongjie) - [#17650](https://github.com/apache/superset/pull/17650) chore: updated screenshots in README.md and added recent events (@srinify) - [#17797](https://github.com/apache/superset/pull/17797) chore(plugin-chart-table): move adhoc filters control closer to the metrics (@kgabryje) - [#17798](https://github.com/apache/superset/pull/17798) chore(plugin-chart-pivot-table): change order of Columns and Rows controls (@kgabryje) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 10a60d65dba72..519487fabd498 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -138,7 +138,7 @@ The best way to report a bug is to file an issue on GitHub. Please include: When posting Python stack traces, please quote them using [Markdown blocks](https://help.github.com/articles/creating-and-highlighting-code-blocks/). -_Please note that feature requests opened as Github Issues will be moved to Discussions._ +_Please note that feature requests opened as GitHub Issues will be moved to Discussions._ ### Submit Ideas or Feature Requests @@ -170,7 +170,7 @@ articles. See [Documentation](#documentation) for more details. ### Add Translations If you are proficient in a non-English language, you can help translate -text strings from Superset's UI. You can jump in to the existing +text strings from Superset's UI. You can jump into the existing language dictionaries at `superset/translations//LC_MESSAGES/messages.po`, or even create a dictionary for a new language altogether. @@ -329,16 +329,16 @@ Triaging goals First, add **Category labels (a.k.a. hash labels)**. Every issue/PR must have one hash label (except spam entry). Labels that begin with `#` defines issue/PR type: -| Label | for Issue | for PR | -| --------------- | --------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- | -| `#bug` | Bug report | Bug fix | -| `#code-quality` | Describe problem with code, architecture or productivity | Refactor, tests, tooling | -| `#feature` | New feature request | New feature implementation | -| `#refine` | Propose improvement that does not provide new features and is also not a bug fix nor refactor, such as adjust padding, refine UI style. | Implementation of improvement that does not provide new features and is also not a bug fix nor refactor, such as adjust padding, refine UI style. | -| `#doc` | Documentation | Documentation | -| `#question` | Troubleshooting: Installation, Running locally, Ask how to do something. Can be changed to `#bug` later. | N/A | -| `#SIP` | Superset Improvement Proposal | N/A | -| `#ASF` | Tasks related to Apache Software Foundation policy | Tasks related to Apache Software Foundation policy | +| Label | for Issue | for PR | +| --------------- | ----------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------- | +| `#bug` | Bug report | Bug fix | +| `#code-quality` | Describe problem with code, architecture or productivity | Refactor, tests, tooling | +| `#feature` | New feature request | New feature implementation | +| `#refine` | Propose improvement such as adjusting padding or refining UI style, excluding new features, bug fixes, and refactoring. | Implementation of improvement such as adjusting padding or refining UI style, excluding new features, bug fixes, and refactoring. | +| `#doc` | Documentation | Documentation | +| `#question` | Troubleshooting: Installation, Running locally, Ask how to do something. Can be changed to `#bug` later. | N/A | +| `#SIP` | Superset Improvement Proposal | N/A | +| `#ASF` | Tasks related to Apache Software Foundation policy | Tasks related to Apache Software Foundation policy | Then add other types of labels as appropriate. @@ -1211,7 +1211,7 @@ To contribute a plugin to Superset, your plugin must meet the following criteria - The plugin should contain sufficient unit/e2e tests - The plugin should use appropriate namespacing, e.g. a folder name of `plugin-chart-whatever` and a package name of `@superset-ui/plugin-chart-whatever` - The plugin should use them variables via Emotion, as passed in by the ThemeProvider -- The plugin should provide adequate error handling (no data returned, malformatted data, invalid controls, etc.) +- The plugin should provide adequate error handling (no data returned, malformed data, invalid controls, etc.) - The plugin should contain documentation in the form of a populated `README.md` file - The plugin should have a meaningful and unique icon - Above all else, the plugin should come with a _commitment to maintenance_ from the original author(s) diff --git a/RELEASING/README.md b/RELEASING/README.md index ab0c6735d1299..8b23dafbf1eea 100644 --- a/RELEASING/README.md +++ b/RELEASING/README.md @@ -238,7 +238,7 @@ Similar to `cherrytree`, the change log script requires a github token, either a #### Initial release (e.g. 1.5.0) -When generating the changelog for an initial minor relese, you should compare with +When generating the changelog for an initial minor release, you should compare with the previous release (in the example, the previous release branch is `1.4`, so remember to update it accordingly): @@ -343,7 +343,7 @@ To build and run the recently created tarball **from SVN**: # login using admin/admin ``` -## Create a release on Github +## Create a release on GitHub After submitting the tag and testing the release candidate, follow the steps [here](https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository) to create the release on GitHub. Use the vote email text as the content for the release description. Make sure to check the "This is a pre-release" checkbox for release candidates. You can check previous releases if you need an example. diff --git a/RELEASING/release-notes-2-0/README.md b/RELEASING/release-notes-2-0/README.md index 193a1e7424b72..265dd32941689 100644 --- a/RELEASING/release-notes-2-0/README.md +++ b/RELEASING/release-notes-2-0/README.md @@ -28,11 +28,11 @@ Superset 2.0 is a big step forward. This release cleans up many legacy code path ## Developer Experience -- Addition of a statsd guage metric for Slack and email notifications for increased visibility into errors around alerts / reports ([#20158](https://github.com/apache/superset/pull/20158)) +- Addition of a statsd gauge metric for Slack and email notifications for increased visibility into errors around alerts / reports ([#20158](https://github.com/apache/superset/pull/20158)) - Helm chart now supports resource limits and requests for each component ([#20052](https://github.com/apache/superset/pull/20052)) -- New Github workflow to test Storybook Netlify instance nightly ([#19852](https://github.com/apache/superset/pull/19852)) +- New GitHub workflow to test Storybook Netlify instance nightly ([#19852](https://github.com/apache/superset/pull/19852)) - Minimum requirement for Superset is now Python 3.8 ([#19017](https://github.com/apache/superset/pull/19017) diff --git a/RELEASING/release-notes-2-0/changelog.md b/RELEASING/release-notes-2-0/changelog.md index 4b3b5ddfaef28..5f66a6a547e98 100644 --- a/RELEASING/release-notes-2-0/changelog.md +++ b/RELEASING/release-notes-2-0/changelog.md @@ -59,7 +59,7 @@ under the License. - [#19898](https://github.com/apache/superset/pull/19898) feat: When editing the label/title in the Metrics popover, hitting Enter should save what you've typed (@diegomedina248) - [#16493](https://github.com/apache/superset/pull/16493) feat(plugin-chart-echarts): [feature-parity] support extra control for the area chart V2 (@stephenLYZ) - [#19855](https://github.com/apache/superset/pull/19855) feat(explore): Frontend implementation of dataset creation from infobox (@lyndsiWilliams) -- [#20165](https://github.com/apache/superset/pull/20165) feat: add modfied col and timezone info to schedule col (@pkdotson) +- [#20165](https://github.com/apache/superset/pull/20165) feat: add modified col and timezone info to schedule col (@pkdotson) - [#20144](https://github.com/apache/superset/pull/20144) feat: showing results pane in dashboard (@zhaoyongjie) - [#20242](https://github.com/apache/superset/pull/20242) feat: derived metrics use different line style (@zhaoyongjie) - [#20010](https://github.com/apache/superset/pull/20010) feat: standardized form_data (@zhaoyongjie) @@ -115,7 +115,7 @@ under the License. - [#19558](https://github.com/apache/superset/pull/19558) feat(explore): Redesign of Run/Save buttons (@kgabryje) - [#19650](https://github.com/apache/superset/pull/19650) feat(embedded): API get embedded dashboard config by uuid (@lilykuang) - [#19310](https://github.com/apache/superset/pull/19310) feat(CRUD): add new empty state (@stephenLYZ) -- [#19622](https://github.com/apache/superset/pull/19622) feat(plugin-chart-echarts): add aggregate total for the Pie/Donuct chart (@stephenLYZ) +- [#19622](https://github.com/apache/superset/pull/19622) feat(plugin-chart-echarts): add aggregate total for the Pie/Donut chart (@stephenLYZ) - [#19314](https://github.com/apache/superset/pull/19314) feat: Move Database Import option into DB Connection modal (@lyndsiWilliams) - [#19434](https://github.com/apache/superset/pull/19434) feat: deprecate old API and create new API for dashes created by me (@dpgaspar) - [#19482](https://github.com/apache/superset/pull/19482) feat: add success toast to alerts and reports (@pkdotson) @@ -181,7 +181,7 @@ under the License. - [#20204](https://github.com/apache/superset/pull/20204) fix: Fixes issue where results panel height was incorrect [sc-49045] (@eric-briscoe) - [#20235](https://github.com/apache/superset/pull/20235) fix: Box Plot Chart throws an error when the average (AVG) / SUM is being calculated on the Metrics (@diegomedina248) - [#20088](https://github.com/apache/superset/pull/20088) fix: datatype tracking issue on virtual dataset (@codemaster08240328) -- [#20220](https://github.com/apache/superset/pull/20220) fix: dashbaord unable to refresh (@zhaoyongjie) +- [#20220](https://github.com/apache/superset/pull/20220) fix: dashboard unable to refresh (@zhaoyongjie) - [#20228](https://github.com/apache/superset/pull/20228) fix: failed samples should throw exception (@zhaoyongjie) - [#20203](https://github.com/apache/superset/pull/20203) fix: move columns to datasource object for bootstrap data (@hughhhh) - [#20151](https://github.com/apache/superset/pull/20151) fix(csv): Ensure df_to_escaped_csv does not coerce integer columns to float (@john-bodley) @@ -191,7 +191,7 @@ under the License. - [#20206](https://github.com/apache/superset/pull/20206) fix(sql lab): SQL Lab Compile Query Delay (@diegomedina248) - [#20201](https://github.com/apache/superset/pull/20201) fix: unable to set destroyOnClose on ModalTrigger (@zhaoyongjie) - [#20186](https://github.com/apache/superset/pull/20186) fix(db): make to allow to show/hide the password when only creating (@prosdev0107) -- [#20127](https://github.com/apache/superset/pull/20127) fix(database): retrival of tables and views from schema for exasol backend (@Nicoretti) +- [#20127](https://github.com/apache/superset/pull/20127) fix(database): retrieval of tables and views from schema for exasol backend (@Nicoretti) - [#19899](https://github.com/apache/superset/pull/19899) fix: always create parameter json field (@pkdotson) - [#20173](https://github.com/apache/superset/pull/20173) fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied (@diegomedina248) - [#20086](https://github.com/apache/superset/pull/20086) fix(css): transparent linear gradient not working in safari (@stephenLYZ) @@ -298,7 +298,7 @@ under the License. - [#19570](https://github.com/apache/superset/pull/19570) fix: sqloxide optional (@betodealmeida) - [#19397](https://github.com/apache/superset/pull/19397) fix: weight tooltip issue (@codemaster08240328) - [#19313](https://github.com/apache/superset/pull/19313) fix(sql lab): increase the size of the action icons in the history tab (@diegomedina248) -- [#19039](https://github.com/apache/superset/pull/19039) fix(explore): clean data when hidding control (@stephenLYZ) +- [#19039](https://github.com/apache/superset/pull/19039) fix(explore): clean data when hiding control (@stephenLYZ) - [#19444](https://github.com/apache/superset/pull/19444) fix: Error Message is cut off in alerts & reports log page (@codemaster08240328) - [#19312](https://github.com/apache/superset/pull/19312) fix: adaptive formatting typo in explore dropdowns (@diegomedina248) - [#19534](https://github.com/apache/superset/pull/19534) fix(explore): Chart header icon paddings (@kgabryje) @@ -463,7 +463,7 @@ under the License. - [#19486](https://github.com/apache/superset/pull/19486) refactor: Removes the CSS files from the Treemap plugin (@michael-s-molina) - [#19488](https://github.com/apache/superset/pull/19488) refactor: Removes the CSS files from the Sunburst plugin (@michael-s-molina) - [#19490](https://github.com/apache/superset/pull/19490) chore: Add theme color to ParallelCoordinates (@geido) -- [#19442](https://github.com/apache/superset/pull/19442) chore: Remove FilterbaleTableStyles.less (@geido) +- [#19442](https://github.com/apache/superset/pull/19442) chore: Remove FilterableTableStyles.less (@geido) - [#19441](https://github.com/apache/superset/pull/19441) chore: Remove StyledQueryButton.less (@geido) - [#19473](https://github.com/apache/superset/pull/19473) refactor: Removes the CSS files from the Rose plugin (@michael-s-molina) - [#19466](https://github.com/apache/superset/pull/19466) chore: Removes hard-coded colors from legacy-plugin-chart-world-map (@michael-s-molina) diff --git a/UPDATING.md b/UPDATING.md index c3f3025365444..542938c35b7a5 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -49,7 +49,7 @@ assists people when migrating to a new version. - [24404](https://github.com/apache/superset/pull/24404): FLASK_ENV is getting deprecated, we recommend using SUPERSET_ENV and reviewing your config for ENVIRONMENT_TAG_CONFIG, which enables adding a tag in the navbar to - make it more clear which envrionment your are in. + make it more clear which environment your are in. `SUPERSET_ENV=production` and `SUPERSET_ENV=development` are the two supported switches based on the default config. - [19242](https://github.com/apache/superset/pull/19242): Adhoc subqueries are now disabled by default for security reasons. To enable them, set the feature flag `ALLOW_ADHOC_SUBQUERY` to `True`. @@ -129,7 +129,7 @@ assists people when migrating to a new version. ## 2.0.1 -- [21895](https://github.com/apache/superset/pull/21895): Markdown components had their security increased by adhering to the same sanitization process enforced by Github. This means that some HTML elements found in markdowns are not allowed anymore due to the security risks they impose. If you're deploying Superset in a trusted environment and wish to use some of the blocked elements, then you can use the HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration to extend the default sanitization schema. There's also the option to disable HTML sanitization using the HTML_SANITIZATION configuration but we do not recommend this approach because of the security risks. Given the provided configurations, we don't view the improved sanitization as a breaking change but as a security patch. +- [21895](https://github.com/apache/superset/pull/21895): Markdown components had their security increased by adhering to the same sanitization process enforced by GitHub. This means that some HTML elements found in markdowns are not allowed anymore due to the security risks they impose. If you're deploying Superset in a trusted environment and wish to use some of the blocked elements, then you can use the HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration to extend the default sanitization schema. There's also the option to disable HTML sanitization using the HTML_SANITIZATION configuration but we do not recommend this approach because of the security risks. Given the provided configurations, we don't view the improved sanitization as a breaking change but as a security patch. ## Breaking Changes @@ -150,8 +150,8 @@ assists people when migrating to a new version. - [19770](https://github.com/apache/superset/pull/19770): Per [SIP-11](https://github.com/apache/superset/issues/6032) and [SIP-68](https://github.com/apache/superset/issues/14909), the native NoSQL Druid connector is deprecated and has been removed. Druid is still supported through SQLAlchemy via pydruid. The config keys `DRUID_IS_ACTIVE` and `DRUID_METADATA_LINKS_ENABLED` have also been removed. - [19274](https://github.com/apache/superset/pull/19274): The `PUBLIC_ROLE_LIKE_GAMMA` config key has been removed, set `PUBLIC_ROLE_LIKE = "Gamma"` to have the same functionality. - [19273](https://github.com/apache/superset/pull/19273): The `SUPERSET_CELERY_WORKERS` and `SUPERSET_WORKERS` config keys has been removed. Configure Celery directly using `CELERY_CONFIG` on Superset. -- [19231](https://github.com/apache/superset/pull/19231): The `ENABLE_REACT_CRUD_VIEWS` feature flag has been removed (premantly enabled). Any deployments which had set this flag to false will need to verify that the React views support their use case. -- [19230](https://github.com/apache/superset/pull/19230): The `ROW_LEVEL_SECURITY` feature flag has been removed (permantly enabled). Any deployments which had set this flag to false will need to verify that the presence of the Row Level Security feature does not interfere with their use case. +- [19231](https://github.com/apache/superset/pull/19231): The `ENABLE_REACT_CRUD_VIEWS` feature flag has been removed (permanently enabled). Any deployments which had set this flag to false will need to verify that the React views support their use case. +- [19230](https://github.com/apache/superset/pull/19230): The `ROW_LEVEL_SECURITY` feature flag has been removed (permanently enabled). Any deployments which had set this flag to false will need to verify that the presence of the Row Level Security feature does not interfere with their use case. - [19168](https://github.com/apache/superset/pull/19168): Celery upgrade to 5.X resulted in breaking changes to its command line invocation. Please follow [these](https://docs.celeryq.dev/en/stable/whatsnew-5.2.html#step-1-adjust-your-command-line-invocation) instructions for adjustments. Also consider migrating you Celery config per [here](https://docs.celeryq.dev/en/stable/userguide/configuration.html#conf-old-settings-map). - [19142](https://github.com/apache/superset/pull/19142): The `VERSIONED_EXPORT` config key is now `True` by default. - [19113](https://github.com/apache/superset/pull/19113): The `ENABLE_JAVASCRIPT_CONTROLS` config key has moved from an app config to a feature flag. Any deployments who overrode this setting will now need to override the feature flag from here onward. @@ -166,7 +166,7 @@ assists people when migrating to a new version. ### Other - [22022](https://github.com/apache/superset/pull/22022): HTTP API endpoints `/superset/approve` and `/superset/request_access` have been deprecated and their HTTP methods were changed from GET to POST -- [21895](https://github.com/apache/superset/pull/21895): Markdown components had their security increased by adhering to the same sanitization process enforced by Github. This means that some HTML elements found in markdowns are not allowed anymore due to the security risks they impose. If you're deploying Superset in a trusted environment and wish to use some of the blocked elements, then you can use the HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration to extend the default sanitization schema. There's also the option to disable HTML sanitization using the HTML_SANITIZATION configuration but we do not recommend this approach because of the security risks. Given the provided configurations, we don't view the improved sanitization as a breaking change but as a security patch. +- [21895](https://github.com/apache/superset/pull/21895): Markdown components had their security increased by adhering to the same sanitization process enforced by GitHub. This means that some HTML elements found in markdowns are not allowed anymore due to the security risks they impose. If you're deploying Superset in a trusted environment and wish to use some of the blocked elements, then you can use the HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration to extend the default sanitization schema. There's also the option to disable HTML sanitization using the HTML_SANITIZATION configuration but we do not recommend this approach because of the security risks. Given the provided configurations, we don't view the improved sanitization as a breaking change but as a security patch. ## 1.5.2 @@ -258,7 +258,7 @@ assists people when migrating to a new version. ### Other - [13772](https://github.com/apache/superset/pull/13772): Row level security (RLS) is now enabled by default. To activate the feature, please run `superset init` to expose the RLS menus to Admin users. -- [13980](https://github.com/apache/superset/pull/13980): Data health checks no longer use the metadata database as an interim cache. Though non-breaking, deployments which implement complex logic should likely memoize the callback function. Refer to documentation in the confg.py file for more detail. +- [13980](https://github.com/apache/superset/pull/13980): Data health checks no longer use the metadata database as an interim cache. Though non-breaking, deployments which implement complex logic should likely memoize the callback function. Refer to documentation in the config.py file for more detail. - [14255](https://github.com/apache/superset/pull/14255): The default `CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC` callable logic has been updated to leverage the specified database and schema to ensure the upload S3 key prefix is unique. Previously tables generated via upload from CSV with the same name but differ schema and/or cluster would use the same S3 key prefix. Note this change does not impact previously imported tables. ## 1.1.0 diff --git a/docker/docker-entrypoint-initdb.d/examples-init.sh b/docker/docker-entrypoint-initdb.d/examples-init.sh index 9a729078239a9..0eaedf2b7e8b0 100755 --- a/docker/docker-entrypoint-initdb.d/examples-init.sh +++ b/docker/docker-entrypoint-initdb.d/examples-init.sh @@ -1,5 +1,5 @@ # ------------------------------------------------------------------------ -# Creates the examples database and repective user. This database location +# Creates the examples database and respective user. This database location # and access credentials are defined on the environment variables # ------------------------------------------------------------------------ set -e diff --git a/scripts/generate_frontend_ts_tasklist.js b/scripts/generate_frontend_ts_tasklist.js index 7f23ad124aefd..5bf85d1e061bd 100644 --- a/scripts/generate_frontend_ts_tasklist.js +++ b/scripts/generate_frontend_ts_tasklist.js @@ -46,7 +46,7 @@ while (directories.length) { // Check for existence of js, jsx, ts, and tsx files. Show a filled box if only ts and tsx, // show an empty box if any js or jsx, and don't print the line if neither exist in the // directory. - const hasTypescriptFiles = + const hasTypeScriptFiles = getFilesByExtensions("./", [".ts", ".tsx"]).length > 0; const hasJavaScriptFiles = getFilesByExtensions("./", [".js", ".jsx"]).length > 0; @@ -57,7 +57,7 @@ while (directories.length) { curDirectory.split("/").length - 1 )}- [ ] \`${curDirectory}\`` ); - } else if (hasTypescriptFiles) { + } else if (hasTypeScriptFiles) { console.log( `${" ".repeat( curDirectory.split("/").length - 1 diff --git a/superset-embedded-sdk/CONTRIBUTING.md b/superset-embedded-sdk/CONTRIBUTING.md index 9bf48e10a1384..37faa04afc8d4 100644 --- a/superset-embedded-sdk/CONTRIBUTING.md +++ b/superset-embedded-sdk/CONTRIBUTING.md @@ -72,6 +72,6 @@ This is used by consumers who install the embedded sdk via npm, yarn, or other p Webpack is used to bundle the `bundle` directory, for use directly in the browser with no build step e.g. when importing via unpkg. -Typescript outputs type definition files to the `dist` directory. +TypeScript outputs type definition files to the `dist` directory. Which of these outputs is used by the library consumer is determined by our package.json's `main`, `module`, and `types` fields.