refactor(frontend): make "Search" box the first filter for charts and…

… datasets (apache#25129)
preset-io · Aug 30, 2023 · eeecd59 · eeecd59
1 parent 66e2807
commit eeecd59
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/superset-frontend/src/pages/ChartList/index.tsx b/superset-frontend/src/pages/ChartList/index.tsx
@@ -589,6 +589,13 @@ function ChartList(props: ChartListProps) {
 
   const filters: Filters = useMemo(() => {
     const filters_list = [
+      {
+        Header: t('Search'),
+        key: 'search',
+        id: 'slice_name',
+        input: 'search',
+        operator: FilterOperator.chartAllText,
+      },
       {
         Header: t('Owner'),
         key: 'owner',
@@ -705,13 +712,6 @@ function ChartList(props: ChartListProps) {
         fetchSelects: loadTags,
       });
     }
-    filters_list.push({
-      Header: t('Search'),
-      key: 'search',
-      id: 'slice_name',
-      input: 'search',
-      operator: FilterOperator.chartAllText,
-    });
     return filters_list;
   }, [addDangerToast, favoritesFilter, props.user]);
 

diff --git a/superset-frontend/src/pages/DatasetList/index.tsx b/superset-frontend/src/pages/DatasetList/index.tsx
@@ -521,6 +521,13 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
 
   const filterTypes: Filters = useMemo(
     () => [
+      {
+        Header: t('Search'),
+        key: 'search',
+        id: 'table_name',
+        input: 'search',
+        operator: FilterOperator.contains,
+      },
       {
         Header: t('Owner'),
         key: 'owner',
@@ -598,13 +605,6 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
           { label: t('No'), value: false },
         ],
       },
-      {
-        Header: t('Search'),
-        key: 'search',
-        id: 'table_name',
-        input: 'search',
-        operator: FilterOperator.contains,
-      },
     ],
     [user],
   );