feat: temporarily disconnect metadata db during long analytics queries #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
reviewed
Dec 5, 2024
eschutho
reviewed
Dec 5, 2024
superset/sqllab/sql_json_executer.py
Outdated
| @@ -101,6 +102,7 @@ def execute( | |||
| raise | |||
| except Exception as ex: | |||
| logger.exception("Query %i failed unexpectedly", query_id) | |||
| logger.error(ex) | |||
There was a problem hiding this comment.
Is this to get some message from the exception logged?
There was a problem hiding this comment.
logger.exception already logs the exception, in addition to the message, it's what differentiates it from logger.error. So this line is not needed.
superset/sqllab/sql_json_executer.py
Outdated
| @@ -101,6 +102,7 @@ def execute( | |||
| raise | |||
| except Exception as ex: | |||
| logger.exception("Query %i failed unexpectedly", query_id) | |||
| logger.error(ex) | |||
There was a problem hiding this comment.
logger.exception already logs the exception, in addition to the message, it's what differentiates it from logger.error. So this line is not needed.
| is_feature_enabled("DISABLE_METADATA_DB_DURING_ANALYTICS") | ||
| and pool_type == "NullPool" | ||
| ) | ||
| conn = db.session.connection() |
There was a problem hiding this comment.
Do we need this? This is just a new connection, it seems like creating it here, closing it in the try and reopening it in the finally will do nothing.
|
made the changes, closing in favor of apache#31315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried some things ... having issues recreating the scoped session.
Hitting a wall with this message -
Instance <Database at 0xffff7c5305e0> is not bound to a Session; attribute refresh operation cannot proceed (Background on this error at: https://sqlalche.me/e/14/bhk3)It's probably just a few lines to restore the database session the right way... Would need to look deeper at the mechanics in https://github.com/pallets-eco/flask-sqlalchemy and reproduce what they do there to re-init the sesh