Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make iFrames Responsive #77

Closed
2 of 8 tasks
SteelWagstaff opened this issue Apr 26, 2018 · 2 comments
Closed
2 of 8 tasks

Make iFrames Responsive #77

SteelWagstaff opened this issue Apr 26, 2018 · 2 comments
Labels
book theme options related to the appearance of a book (its theme) and what a user can control without using custom CSS media & embeds related to media file uploads and embedded elements reading interface

Comments

@SteelWagstaff
Copy link
Member

Feature Scope

  • Accessibility and inclusivity
  • User interface (content creation)
  • User interface (network home page & catalog)
  • User interface (reading)
  • Import/export formats
  • Authoring tools
  • Book themes
  • Integration with third-party services

Feature Description

I'd like to make iFrames embedded in Pressbooks size responsively. In particular, it would be nice to have videos and other elements inserted through oEmbed be resized as browser width changes. One possible model for implementation might be https://gist.github.com/jlengstorf/ce2470df87fd9a892f68.

Feature Use Case

This should benefit anyone who embeds interactive content in their site using oEmbeds. Currently, many oEmbed links include height and width values in their inline styling, which causes display problems, particularly on mobile devices. See the screenshots below for one example of a modestly-sized Youtube video on a narrow browser width:
screen shot 2018-04-26 at 11 59 53 am
screen shot 2018-04-26 at 11 59 44 am
@greatislander greatislander added reading interface book theme options related to the appearance of a book (its theme) and what a user can control without using custom CSS labels Apr 26, 2018
@SteelWagstaff
Copy link
Member Author

Related: pressbooks/pressbooks-book#592

@SteelWagstaff SteelWagstaff added the media & embeds related to media file uploads and embedded elements label Nov 29, 2019
@SteelWagstaff
Copy link
Member Author

Closing in favor of pressbooks/pressbooks-book#721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
book theme options related to the appearance of a book (its theme) and what a user can control without using custom CSS media & embeds related to media file uploads and embedded elements reading interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greatislander @SteelWagstaff