-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native] Documentation structure, pending PR discussion. #19084
Comments
@Fiooodooor I started a discussion here #19077 I will close that and paste my thoughts here Prestissimo README can benefit from some restructuring. I propose the following changes Add a Presto Wiki page for Prestissimo design, Velox integration, and limitations. Below are the sections I feel the README should address. @Fiooodooor You seem to have another handle @Mionsz. Can you consider using one to avoid losing updates? |
We cannot practically maintain and support all the Linux distros. As new Linux versions emerge, and the Velox dependencies evolve, it is possible that the setup scripts can go out of date. |
As Ubuntu is also very popular in both servers and development environments, and we already have ubuntu scripts in the repo, it would be good if we could maintain the docs for Ubuntu. There is a new LTS Ubuntu release every two years, it might not be a big problem. However, maintaining it in issues or wiki also sounds good. |
Let's keep the Ubuntu setup script in the repo since it's popularly used. We can mention in the README which setup scripts are regularly tested and which are not. |
@Fiooodooor, @bianhq do you have any concerns or thoughts about my proposal? |
@majetideepak I think it would be simple and clear to have separate md files for different OS, just like the setup scripts. Putting instructions for all the platforms on a single page could make the doc long and hard to follow. On the main readme.md, we can put the table of contents, introduction, common rules, links to the other doc pages, and maybe a quick start (e.g., for docker or MacOS). |
@bianhq what is the need for separate md files for each OS? Can you clarify the instructions that are unique for each OS? |
I like the way that we have a separate page for each OS. People do different things on different OSs. For example, MacOS users are not likely to set up a testing cluster using the command line to run queries on large datasets. And, if I am a newcomer to Prestissimo and I am working on Ubuntu, I do not want to see 'MacOS' and 'CentOS' everywhere in the README (like what we do now). If we do not add the notes or subsections for different OS, we must ensure the instructions work on each OS, this is also not an easy job. So I think having separate files for different OS is more clear, an example is the vTune doc: https://www.intel.com/content/www/us/en/develop/documentation/vtune-install-guide/top.html. Anyway, this is just my personal opinion. If we can make a single page very clear or if there are overheads to maintaining separate files, I support having a single page. |
@bianhq thanks for this feedback. I am fine with creating a subsection for each OS as long as there is no duplication. For example, the CLion and Intellij setup is the same on both MacOS and Ubuntu, so we need to keep a single version to simplify the maintenance. |
After having the consensus on naming convention and seeing that efforts are being made to document the project the natural next step is the documentation structure discussion itself. This would include:
Bellow is the list of pull requests and issues connected to or extending this topic:
Pull request list:
[native] Readme update: [native] Readme update #19049
[native] Add document for Building Prestissimo on Ubuntu: [native] Add document for Building Prestissimo on Ubuntu. #19079
Improve Prestissimo README: Improve Prestissimo README #19075
Issues list:
[native] Naming convention clarification: [native] Naming convention clarification #18721
@rohanpednekar @majetideepak @mbasmanova
CC: @psbell-meta @aditi-pandit @amitkdutta @xiaoxmeng
The text was updated successfully, but these errors were encountered: