Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant comments #490

Closed
Rangi42 opened this issue Jan 29, 2025 · 1 comment
Closed

Remove redundant comments #490

Rangi42 opened this issue Jan 29, 2025 · 1 comment

Comments

@Rangi42
Copy link
Member

Rangi42 commented Jan 29, 2025

Many comments are just restating what's obvious from modern label and constant names (although they were more relevant when the disassembly was still in progress and things were unidentified). Some regexes that help find many instances of them:

  • git grep -P '^\t(ld [abcdehl],|call( n?[zc],)?|j[pr]( n?[zc],)?|cp) [A-Z][A-Za-z0-9_]+ ; '
  • git grep -P '^\tldh? a, \[[whv][A-Z].+\] ; '
  • git grep -P '^\t(bit|res|set) [A-Z][A-Za-z0-9_]+, \S+ ; '

(Those turn up hundreds of lines, and many of them are false positives, useful comments that we should keep or maybe reword or occasionally turn into ASSERTs.)

@dannye
Copy link
Member

dannye commented Jan 29, 2025

lol this is a dupe of #302

@Rangi42 Rangi42 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants