Fix/#279 3차 스프린트 기간 지도편지 수정 #280
Merged
+91
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
l2yujw
approved these changes
Jan 31, 2025
| @@ -258,6 +259,15 @@ public Page<FindAllArchiveLetters> findArchiveLetters(int page, int size, Long u | |||
|
|
|||
| @Transactional | |||
| public void deleteArchivedLetter(DeleteArchivedLettersRequestDTO deleteArchivedLettersRequestDTO, Long userId) { | |||
| for (Long archiveId : deleteArchivedLettersRequestDTO.letterIds()) { | |||
| MapLetterArchive findArchiveInfo = mapLetterArchiveRepository.findById(archiveId); | |||
There was a problem hiding this comment.
계속
findById로 db에 접근하는것 보다 findAllById로 해서 한번에 받아온 뒤에 로컬에서 처리하는 방식으로 하는건 어떨까요?
List<MapLetterArchive> archiveInfos = mapLetterArchiveRepository.findAllById(deleter~~.letterIds());
for(archiveInfo : archiveInfos) {
archiveInfo.validDeleteArchivedLetter(userId);
mapLetterArchiveRepository.deleteById(archiveInfo.id);
}이런 느낌이 가능한 코드라면 이렇게 하는거 어떤지 의견 드려봅니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 기능 설명
까먹을까봐 미리 적어요! 다음 회의 때 2차 스프린트 기간에 수정한 api 프론트 변경 여부 물어보고, 수정 전 코드 삭제할게요!!
연결된 issue
연결된 issue를 자동을 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #279
✅ 체크리스트