Alias clashes

[cpiemontese]

Here's a snippet of an Avro schema definition:

fields: [
  %{
    type: [:null, @v1_namespace_prefix <> ".example.MetaData"],
    default: nil,
    name: :metadata,
    doc: "Metadata for example - to be deprecated"
  },
  %{
    type: %{type: :array, items: @v2_namespace_prefix <> ".example.MetaData"},
    name: :metadata_records,
    doc:
      "A list of one metadata for each example in this chain, sorted chronologically (earliest first)."
  },
  ...
]

This generates the following aliases:

alias Schema.Generated.Prefix.V1.Example.MetaData
alias Schema.Generated.Prefix.V2.Example.MetaData

Due to the name clash of the last module part (MetaData), the first alias is overridden.
The generated code actually always expects V2 MetaData despite the avro schema itself expecting V1:

"fields": [
  {
    "name": "metadata",
    "type": [
      "null",
      "schema.v1.example.MetaData"
    ]
  },
  {
    "name": "metadata_records",
    "type": {
      "items": "schema.v2.example.MetaData",
      "type": "array"
    }
  },
  ...
],

We need to either

• contrive names to not clash, or
• fix the code in avrogen's lib/avrogen/avro/types/record.ex to make and use aliases that don't clash or
• just don't use aliases at all.

Related cards:

• https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/DEVEX-2348/avrogen-alias-clashes
• https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PUWEN-1741/avrogen-dont-rely-on-map-order