Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: ConfirmDialog #16861

Closed
shaman-apprentice opened this issue Nov 27, 2024 · 3 comments
Closed

Component: ConfirmDialog #16861

shaman-apprentice opened this issue Nov 27, 2024 · 3 comments
Assignees
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Milestone

Comments

@shaman-apprentice
Copy link
Contributor

shaman-apprentice commented Nov 27, 2024

Describe the bug

Confirmation Dialog has neither a confirm nor a cancle button.

Environment

All

Reproducer

Bug is present in current demo https://v18.primeng.org/confirmdialog

Angular version

18.x.x

PrimeNG version

18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.10.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Go to https://v18.primeng.org/confirmdialog
  2. Click on "Delete"-button of first demo
  3. Neither a confirm nor a cancle button is present.

Expected behavior

Confirm and cancle button are present.

@shaman-apprentice shaman-apprentice added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 27, 2024
@ImClieo
Copy link

ImClieo commented Nov 27, 2024

This seems to be due to some infinite loop happening when trying to determine a focus.
The specific error is a maximum call stack exceeded:

chunk-XM76ZT77.js:7 ERROR RangeError: Maximum call stack size exceeded
    at RegExp.exec (<anonymous>)
    at t.parseDurationToMilliseconds (chunk-TIN5GBLU.js:152:10562)
    at t.focus (chunk-TIN5GBLU.js:152:10718)
    at t.focus (chunk-TIN5GBLU.js:152:11018)
    at t.focus (chunk-TIN5GBLU.js:152:11018)
    at t.focus (chunk-TIN5GBLU.js:152:11018)
    at t.focus (chunk-TIN5GBLU.js:152:11018)
    at t.focus (chunk-TIN5GBLU.js:152:11018)
    at t.focus (chunk-TIN5GBLU.js:152:11018)
    at t.focus (chunk-TIN5GBLU.js:152:11018)

The dynamic dialog have the same kind of problem, this can however be fixed by setting the focusOnShow config option.

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 28, 2024
@mertsincan mertsincan added this to the 18.0.0-rc.2 milestone Nov 28, 2024
@mehmetcetin01140 mehmetcetin01140 added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 2, 2024
@mehmetcetin01140 mehmetcetin01140 moved this to Done in PrimeNG Dec 2, 2024
@mehmetcetin01140 mehmetcetin01140 closed this as completed by moving to Done in PrimeNG Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@shaman-apprentice
Copy link
Contributor Author

I can confirm, that this was fixed with 18.0.0-rc.2 - although it is not in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Cannot Replicate Issue could not be replicated by Core Team
Projects
Status: Done
Development

No branches or pull requests

5 participants