-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with AnchorNav
setting the primary action to be styled as a primary button
#826
Comments
@rezrah you think we should force the outline button if there is only one CTA? I mean that's ok with me, but not what we got in the designs... I personally prefer the primary action, and then if we have another one we use the secondary outline for it... But that's just my preference... |
Looping in Site FR @natalie-iv |
@stamat It turns out that you can forward the <AnchorNav>
<AnchorNav.Action variant="primary">Sign up</AnchorNav.Action>
</AnchorNav> We're only providing sensible defaults in the component, not enforcing them. This means you can forward all the usual Button props to that component. This should meet the requirements of your request. FWIW we're going to make a few changes to AnchorNav following a convo with Site yesterday:
|
@rezrah ah TMYK! Thanks legend! ✨ |
@rezrah eeeeeerrrrrr.... I think I tried variant before... |
I wanted to style the primary action of the
AnchorNav.Action
as the primary button. It defaults to secondary styles. In order to use the primary button styles we need to have two buttons. I couldn't find anything in the docs. Maybe this is the intended behavior?Anyway I came up with a hack for this... Is there a non hacky way to achieve this
The text was updated successfully, but these errors were encountered: