Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pg-cf-hyperdrive): improve delete hyperdrive script #4915

Merged
merged 9 commits into from
May 7, 2024

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented May 7, 2024

It's failing on the default branch dev, it looks like the script cannot recover if the hyperdrive config does not exist because it will try to delete it and fail.

This adds a check that if it does not exist, it continues.

@Jolg42 Jolg42 marked this pull request as ready for review May 7, 2024 11:48
@Jolg42 Jolg42 requested review from janpio, SevInf and jkomyno as code owners May 7, 2024 11:48
@Jolg42 Jolg42 changed the title test(pg-cf-hyperdrive): debug script test(pg-cf-hyperdrive): improve delete hyperdrive script May 7, 2024
@Jolg42 Jolg42 added this to the 5.14.0 milestone May 7, 2024
@Jolg42
Copy link
Contributor Author

Jolg42 commented May 7, 2024

@Jolg42
Copy link
Contributor Author

Jolg42 commented May 7, 2024

Merging to bring back the suite into a passing state.

@Jolg42 Jolg42 merged commit f13b1f4 into dev May 7, 2024
54 checks passed
@Jolg42 Jolg42 deleted the joel/pg-cf-hyperdrive branch May 7, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant