rulefile: enabled use of subids only #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jankraing FYI - the issues was somewhere else - the added testcase shows that for your reported bug it should work fine now |
In the latest rework an issues slipped in that allowed only entire groups (or ID) to be enabled/disabled, mind the subIDs as well when loading the rules. As they are filtered out afterwards it should be fine. This applies of course only to the rule itself, thus we don't run into conflicts with the fix method call Closes #436 Signed-off-by: Konrad Weihmann <[email protected]>
priv-kweihmann
force-pushed
the
fix/rule-file-subid-only
branch
from
f6df319 to
2786f9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest rework an issues slipped in that
allowed only entire groups (or ID) to be
enabled/disabled, mind the subIDs as well when
loading the rules.
As they are filtered out afterwards it should be fine. This applies of course only to the rule itself,
thus we don't run into conflicts with the fix method call
Closes #436
Pull request checklist
Bugfix
New feature