Add FieldBits impl for Secp256r1 & remove utils module
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't make much sense to have a `utils` module which in reality just has one function that only integration tests require. So, chore: Move `fe_from_str` to integration tests file removing code from the lib itself.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make much sense to have a
utilsmodule which in realityjust has one function that only integration tests require.
So, chore: Move
fe_from_strto integration tests file removing codefrom the lib itself.
Also, notice that the CI was giving an unused warning for
MODULUS_32BITSfor secp256r1. After checking I saw that it was not used because we weren't implementingFieldBitsfor it.So this PR also adds this.