Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal handling of signature assignment and management #44

Open
CPerezz opened this issue Sep 8, 2022 · 1 comment
Open

Internal handling of signature assignment and management #44

CPerezz opened this issue Sep 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@CPerezz
Copy link
Member

CPerezz commented Sep 8, 2022

It was a nightmare and really error-prone to implement correctly all the steps in https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/6abc33eeb81ffd64ff73f2a84c04203f33c161eb/eth-types/src/sign_types.rs#L100 when we migrated to the latest halo2 and halo2wrong tags.

It will be much better if the secp256k1 crate would handle these kind of things for us.

We could maybe even create a secp256k1-sign crate which handles all that for us and abstracts complexity in the downstream crates.
This would help significantly to reduce code there and also, would place in the correct repo all the signature-related logic.

@CPerezz CPerezz added the enhancement New feature or request label Sep 8, 2022
@CPerezz CPerezz changed the title Internal handling of signature assignment Internal handling of signature assignment and management Sep 8, 2022
@ed255 ed255 moved this to 🆕 Product Backlog Items in zkEVM Community Edition Sep 9, 2022
@CPerezz CPerezz moved this from 🆕 Product Backlog Items to 📋 Refined Backlog in zkEVM Community Edition Jan 17, 2023
@CPerezz
Copy link
Member Author

CPerezz commented Jan 17, 2023

Seolved via #59 when resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant