-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording in the tutorials #48
Update wording in the tutorials #48
Conversation
Note, I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @psteinb, thanks for the feedback and fixes! I agree with most of your additions but made a few wording suggestions.
I still have to check that the UTF-8 edits display correctly in the docs and locally.
Co-authored-by: François Rozet <[email protected]>
Co-authored-by: François Rozet <[email protected]>
Co-authored-by: François Rozet <[email protected]>
Co-authored-by: Peter Steinbach <[email protected]>
Just saw that this is merged. Thanks so much for the trust. And sorry for not replying to your question here. Is this still an open issue? |
No problem, thank you for the edits, I think the tutorial is much clearer now!
I think its fine like it is now. Feel free to open another PR if you want to improve the tutorials (or add new ones), though! |
While I was working through the tutorial (which are great!), I took the liberty of refining some wording. I very few mistakes of English language. I also added some bits here and there to make the tutorials more readable (for someone like me). I hope you find this useful.