Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change von_mises_rot2 to vmf_rot2 for naming consistency #6

Open
agarret7 opened this issue Sep 25, 2020 · 1 comment
Open

Change von_mises_rot2 to vmf_rot2 for naming consistency #6

agarret7 opened this issue Sep 25, 2020 · 1 comment
Assignees
@marcoct

Comments

@agarret7
Copy link
Contributor

The VMF distribution for Rotation{3} is called vmf_rot3, but the name for Rotation{2} is von_mises_rot2. We should change the name of the latter to be consistent.
@marcoct
Copy link
Collaborator

marcoct commented Sep 25, 2020

VMF stands for von Mises Fisher distribution, which is a distribution on general hyperspheres. The von Mises distribution is the special case for circles i.e. angles. We could rename vmf to von_mises_fisher I suppose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoct marcoct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoct @agarret7