You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Good question -- it's really for support that's too large to tractably enumerate, not just infinite support. It is used whenever preferred values are used (it's the "other" token from the PClean paper).
marcoct
changed the title
Why does StringPrior use ProposalDummyValue?
Document the role of ProposedDummyValue
Mar 6, 2021
marcoct
changed the title
Document the role of ProposedDummyValue
Document the role of proposal dummy values
Mar 6, 2021
This text implies that
ProposalDummyValue
s are only used for distributions that have infinite (and discrete) support:https://github.com/probcomp/PClean/blob/master/src/distributions/distributions.jl#L10-L14
But
StringPrior
has finite support (there is a maximum length), and it implementsdiscrete_proposal_dummy_value
:https://github.com/probcomp/PClean/blob/master/src/distributions/string_prior.jl#L23-L25
The text was updated successfully, but these errors were encountered: