This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Show errors for line stacked – not just one per line #26
Labels
Comments
jukben
added a commit
that referenced
this issue
Mar 26, 2019
This PR introduce aditional check for named imports – they should be ordered alphabetically too. Has fixer.
In this PR is also fix, because asterisk imports were sorted wrongly. (The AST is really crazy for this case)
e.g:
```tsx
import * as X, { x, y, z } from 'XY';
import { x, y, z } from 'XY';
```
@karelskopek gonna be happy I guess. 🚀
This also introduce very minor bug (#26) – in case where you have wrongly ordered named imports you won't get info about that you have wrongly ordered whole line. You get just one error per lime. Fixer works correctly tho. It's low prio, because everyone should use autofixer instead of manual fixing. ([issue could be observed here, as you can see, it gets fixed correctly](https://github.com/productboardlabs/tslint-pb/pull/25/files#diff-50eda79059f42d010ea9aaf07797da76R4))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Because in #25 we introduce possibility of multiple errors per one line. We should be able to report it correctly.
doesItFollowConventionmethod needs to be updated accordingly.The text was updated successfully, but these errors were encountered: