optimize getlecture #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
Summary
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
DaymasS
requested changes
Nov 17, 2024
rating_api/routes/lecturer.py
Outdated
Comment on lines
124
to
137
| result.mark_freebie, result.mark_kindness, result.mark_clarity = 0, 0, 0 | ||
|
|
||
| for comment in approved_comments: | ||
| result.mark_freebie += comment.mark_freebie | ||
| result.mark_kindness += comment.mark_kindness | ||
| result.mark_clarity += comment.mark_clarity | ||
|
|
||
| general_marks = [ | ||
| lecturer_to_result.mark_freebie, | ||
| lecturer_to_result.mark_kindness, | ||
| lecturer_to_result.mark_clarity, | ||
| result.mark_freebie / len(approved_comments), | ||
| result.mark_kindness / len(approved_comments), | ||
| result.mark_clarity / len(approved_comments), | ||
| ] | ||
| lecturer_to_result.mark_general = sum(general_marks) / len(general_marks) | ||
| result.mark_general = sum(general_marks) / len(general_marks) | ||
|
|
There was a problem hiding this comment.
result изначально имеет вид:
class LecturerGetAll(Base):
lecturers: list[LecturerGet] = []
limit: int
offset: int
total: intА тут вместо добавления оценок лекторам, создаются новые поля в result и перезаписываются при каждой итерации по лектору
There was a problem hiding this comment.
Аналогично нужно поправить ручку get_lecturer
DaymasS
reviewed
Nov 17, 2024
There was a problem hiding this comment.
Также выкатили пр на тесты, так что стоит написать тесты на:
- Запрос всех лекторов с комментами
- Запрос одного лектора с комментами
- Запрос всех лекторов с оценками
- Запрос одного лектора с оценками
|
💩 Code linting failed, use |
|
💩 Code linting failed, use |
1 similar comment
|
💩 Code linting failed, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения:
В get lecturer оставил всего один цикл for по всем комментариям, чтобы улучшить реализацию, а также, все проверки производятся на каждой итерации.
Детали реализации:
Простым языком, я ввёл переменные result.mark_freebie, result.mark_kindness, result.mark_clarity и в них на цикле for забиваются значения оценок по разным критериям, после вводим список general_marks в который кладем среднее арифметическое от оценок лежащих в каждом из resalts. После этого делаем последний шаг - Находим среднее арифметическое всех видов оценок (халявность, полярность, доброта). Вот и всё дорогой проверяющий.
Check-List
blackиisortдля Back-End илиPrettierдля Front-End?