Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit button and StylePtr Wrapper affecting Right Column update. #8

Open
NoSloppy opened this issue Jul 22, 2020 · 11 comments
Open

Submit button and StylePtr Wrapper affecting Right Column update. #8

NoSloppy opened this issue Jul 22, 2020 · 11 comments

Comments

@NoSloppy
Copy link
Contributor

Hitting the Expand button somehow sets something up so a subsequent submit makes the right column condense to one long string and needs a page refresh before anything works.

Also, after editing something, pasting a style in the box requires hitting submit 2x before the right column refreshes. The animation window updates with the first press of submit. In my example it's the same style, but I just edited the InOutHelper example template, pasted my style, hit submit....the animation updated, but the right side was still InOutHelper style until 2nd press of submit.
Hard to word this , sorry.

Video here:
https://www.youtube.com/watch?v=G14ejAtOCxI

@profezzorn
Copy link
Owner

I guess I should have been more clear: Please file one issue for each individual problem.
Also, I have some questions; Does this happen for every style, or just some?
If it happens for some styles, please paste the style that it is happening with. (I don't want to type it all in from the video.)

@NoSloppy
Copy link
Contributor Author

Sorry again. Ok so I'lll make the Expand a separate thing, this will be for the Submit button 2x issue then, ok?

I think the issue has something to do with stripping the StylePtr off of the pasted style.

So using only the styles on the site, this can be recreated as follows:
Opening Examples tab, choose first example InOutHelper......
Press Power to view blue blade.
Press Copy button, adds StylePtr wrapper.
Click base color in right hand column, change to Yellow lets say.
Click outermost bracket in right hand column to reselect entire style, Yellow blade is shown.
Select all text in style box and paste in the copied, StylePtr wrapped blue blade style, and press Submit.
Blue blade shows up top, but right hand column doesn't update until 2nd press of Submit.

@NoSloppy NoSloppy changed the title Right Column updating and refreshing issue Submit button and StylePtr Wrapper affecting Right Column update. Jul 22, 2020
@profezzorn
Copy link
Owner

I think this should be fixed now.

@NoSloppy
Copy link
Contributor Author

NoSloppy commented Aug 9, 2020

I think this should be fixed now.

Confirmed. One press of submit after pasting a StylePrt<>() wrapped style copied from config file working.
Also //comments not interfering. Thanks! Great work as always.

@NoSloppy
Copy link
Contributor Author

Retracted. Still doing it for me.
Today, I am simply using the editor to reformat long, single line styles to multi-line by layers.
Pasted the following style, hit submit, right column not updated until submit hit second time. Repeated same for multiple styles with same result.

StylePtr<InOutSparkTip<OnSpark<TransitionEffect<TransitionEffect<OnSpark<LocalizedClash<Lockup<Blast<AudioFlicker<Red,Rgb<120,0,0>>,DeepSkyBlue>,Pulsing<Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,3500>,AudioFlicker<Red,White>>,White,80>,White,250>,White,TrJoin<TrWipe<50>,TrWipeIn<50>>,TrFade<100>,EFFECT_LOCKUP_BEGIN>,Pulsing<Gradient<Red,Gradient<Red,White,Red>,Red>,Rgb<120,0,0>,1000>,TrBoing<100,1>,TrJoinR<TrWipe<500>,TrWipeIn<500>>,EFFECT_LOCKUP_END>,White,250>,1000,300>>(),

@profezzorn
Copy link
Owner

Is it because of the extra comma at the end?

@NoSloppy
Copy link
Contributor Author

Actually, additionally, this style pastes and doesn't layerize (expected) However, if the right column IS NOT clicked before hitting copy button, the original pasted StylePtr<>() is not stripped off, and ends up with an extra closing () added to the end, which, if pasted into a config will cause compiling error

@NoSloppy
Copy link
Contributor Author

Staring style to paste in:
StylePtr<InOutSparkTip<OnSpark<TransitionEffect<TransitionEffect<OnSpark<LocalizedClash<Lockup<Blast<AudioFlicker<Red,Rgb<120,0,0>>,DeepSkyBlue>,Pulsing<Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,3500>,AudioFlicker<Red,White>>,White,80>,White,250>,White,TrJoin<TrWipe<50>,TrWipeIn<50>>,TrFade<100>,EFFECT_LOCKUP_BEGIN>,Pulsing<Gradient<Red,Gradient<Red,White,Red>,Red>,Rgb<120,0,0>,1000>,TrBoing<100,1>,TrJoinR<TrWipe<500>,TrWipeIn<500>>,EFFECT_LOCKUP_END>,White,250>,1000,300>>(),

Result if copy button pressed before editing or clicking right column:
StylePtr<InOutSparkTip<OnSpark<TransitionEffect<TransitionEffect<OnSpark<LocalizedClash<Lockup<Blast<AudioFlicker<Red,Rgb<120,0,0>>,DeepSkyBlue>,Pulsing<Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,3500>,AudioFlicker<Red,White>>,White,80>,White,250>,White,TrJoin<TrWipe<50>,TrWipeIn<50>>,TrFade<100>,EFFECT_LOCKUP_BEGIN>,Pulsing<Gradient<Red,Gradient<Red,White,Red>,Red>,Rgb<120,0,0>,1000>,TrBoing<100,1>,TrJoinR<TrWipe<500>,TrWipeIn<500>>,EFFECT_LOCKUP_END>,White,250>,1000,300>>(),
()

@NoSloppy
Copy link
Contributor Author

Is it because of the extra comma at the end?

Seems like yes. Pasting without comma at end has right column update on first press. With comma, second press of submit required.

@profezzorn profezzorn reopened this Aug 10, 2020
@profezzorn
Copy link
Owner

The overall issues seems to be that the style editor ignores any extra crap after the style, but when a selection is made on the right, this doesn't work because it actually inserts whatever you put in the text box inside the "full" style listed on the right. At that point, the "extra crap" isn't at the end anymore, but it's now somewhere in the middle, which doesn't work.

The style editor should be a lot more consistent about this, and either explicitly delete the extra junk at the end, or never allow it at all.

@NoSloppy
Copy link
Contributor Author

NoSloppy commented Apr 2, 2023

Back to this one.
I tried the example style above and it just gets stuck in a parsing loop. the page becomes unresponsive and needs to have browser window closed to kill it.

StylePtr<InOutSparkTip<OnSpark<TransitionEffect<TransitionEffect<OnSpark<LocalizedClash<Lockup<Blast<AudioFlicker<Red,Rgb<120,0,0>>,DeepSkyBlue>,Pulsing<Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,Gradient<AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>,BrownNoiseFlicker<White,Strobe<SteelBlue,White,50,1>,100>,AudioFlicker<Red,Rgb<120,0,0>>,AudioFlicker<Red,Rgb<120,0,0>>>,3500>,AudioFlicker<Red,White>>,White,80>,White,250>,White,TrJoin<TrWipe<50>,TrWipeIn<50>>,TrFade<100>,EFFECT_LOCKUP_BEGIN>,Pulsing<Gradient<Red,Gradient<Red,White,Red>,Red>,Rgb<120,0,0>,1000>,TrBoing<100,1>,TrJoinR<TrWipe<500>,TrWipeIn<500>>,EFFECT_LOCKUP_END>,White,250>,1000,300>>(),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants