Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend test coverage in time_advance-tests #373

Open
bmcdanie opened this issue Jan 21, 2021 · 2 comments
Open

extend test coverage in time_advance-tests #373

bmcdanie opened this issue Jan 21, 2021 · 2 comments
Assignees
Labels
hardening non bugfix/performance improvements

Comments

@bmcdanie
Copy link
Collaborator

currently, we test only that the wavelet space solution for each problem at a given timestep matches the MATLAB solution for that problem/timestep. we could fairly simply extend these tests to also test that the difference between wavelet space solution and analytic solution (for problems with analytic solution) also matches. this will ensure we have consistent analytic solutions generated at every timestep.

@bmcdanie bmcdanie added the hardening non bugfix/performance improvements label Jan 21, 2021
@hbrunie
Copy link
Collaborator

hbrunie commented Jan 25, 2021

Are these tests extended to double and single precision ? (are we testing ASGARD_DOUBLE_PRECISION OFF)?

@bmcdanie
Copy link
Collaborator Author

yes - that macro is only used to control precision in main, but time advance tests are templated to run in single and double precision.

@hbrunie hbrunie self-assigned this Sep 3, 2021
This was referenced Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardening non bugfix/performance improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants