Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /metrics endpoint for timeseries database integration #207

Open
reidlai opened this issue Jun 1, 2020 · 4 comments
Open

add /metrics endpoint for timeseries database integration #207

reidlai opened this issue Jun 1, 2020 · 4 comments

Comments

@reidlai
Copy link

reidlai commented Jun 1, 2020

Current behavior:
Found project-flogo/services have flow-state and flow-store. Based on my understanding, we need to call api in order populate data into these two service. For flogo-state, i am expecting this will integrate with timeseries database likei InfluxDB or Prometheus.

Expected behavior:
Should implmenet /metrics endpoint for each flogo app by default. The metrics should show simple success or failure counts for triggers and each activities in flow or stream.

What is the motivation / use case for changing the behavior?
Developer can focus on code and SRE can just set up scrape or poll for statistics collection without coding effort

If flow-state server goes down, all apps depends on flow-state server will lost all statistics.

Additional information you deem important (e.g. I need this tomorrow):

@lixingwang
Copy link
Contributor

@reidlai Thanks for your issue. the infrastructure code is there for flow. It has trigger/flow and task events. What you can do it just write your event listener and registry to engine and start listen.

@fm-tibco we should put some sample event listener code in flow repo.

@reidlai
Copy link
Author

reidlai commented Jun 5, 2020

I understand I can add actions and flows to provide the metrics. But it will be tedious if having many microservice app.

@vijaynalawade
Copy link
Contributor

@reidlai: What @lixingwang meant was to write something like https://github.com/TIBCOSoftware/flogo/wiki/Publish-and-Subscribe-Audit-Events. You can write this custom listener and include it in your app binary. It will work for any microservice. By the way, this feature is supported OOTB in enterprise version of Flogo.

@reidlai
Copy link
Author

reidlai commented Jun 18, 2020

@reidlai: What @lixingwang meant was to write something like https://github.com/TIBCOSoftware/flogo/wiki/Publish-and-Subscribe-Audit-Events. You can write this custom listener and include it in your app binary. It will work for any microservice. By the way, this feature is supported OOTB in enterprise version of Flogo.

Let me take a look and thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants