Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Layout 컴포넌트 추가 #5

Merged
merged 7 commits into from
May 29, 2023
Merged

feat: Layout 컴포넌트 추가 #5

merged 7 commits into from
May 29, 2023

Conversation

bytrustu
Copy link
Member

@bytrustu bytrustu commented May 27, 2023

작업 주제

  • Layout 컴포넌트 추가

작업 내용(어떤 부분을 리뷰어가 집중해서 봐야할까요?)

  • Box 컴포넌트 추가 (vanila extract sprinkle 이슈가 있어서 관련 코드를 제거했습니다.) Imports inside .css.ts files produce an error (Next Js) vanilla-extract-css/vanilla-extract#1043

  • Layout 컴포넌트 추가

  • 유틸 타입 추가

    • HTMLOverridableProps, Combine
    • 컴포넌트에 HTML 태그들을 as 속성으로 반영할수 있도록 HTMLOverridableProps 타입을 만들어봤어요.
      ComponentPropsWithRef<T> 를 통해서 해당 태그의 프로퍼티들을 받을수 있도록 했습니다.
  • styleToken space 추가

화면 스크린샷

layout.mp4

체크리스트(PR 올리기 전 아래의 내용을 확인해주세요.)

  • base, compare branch가 적절하게 선택되었나요?
  • 로컬 환경에서 충분히 테스트 하셨나요?

리뷰 규칙

  • P1: 꼭/적극적 반영해 주세요 (Request changes)
  • P2: 웬만하면 반영해 주세요 (Comment)
  • P3: 반영해도 좋고 넘어가도 좋습니다 (Approve)

@bytrustu bytrustu changed the base branch from feature/theme to staging May 28, 2023 16:49
@bytrustu bytrustu changed the title feat: Box 컴포넌트 추가 feat: Layout 컴포넌트 추가 May 29, 2023
@bytrustu bytrustu merged commit 9a07b9b into staging May 29, 2023
@bytrustu bytrustu deleted the feature/ui-box branch May 29, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant