Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module deployment should not register World-level function selectors #11

Open
MerkleBoy opened this issue Feb 27, 2024 · 0 comments
Open

Comments

@MerkleBoy
Copy link
Contributor

Right now, we're deploying our contract suite through MUD's CLI, but it comes at the cost of automatically registering all methods in each Systems as World-functions.

While it is handy to have direct access to certain core methods by making direct calls to world, and because each modules are deployed on specific namespaces, the resulting function selectors registered corresponds to some concatenation of namespace and methodName
==> MySystem.foo().selector (deployned on namespace xyz) becomes xyz__foo().selector

I'd be in favour of registering our function suite manually so we can remove the xyz__ part, that way, function selectors will be an exact match of each system's interface, independantly of where those modules ends up being registered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant