Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File uploads: handle upload errors #197

Open
winged opened this issue Jul 7, 2021 · 1 comment
Open

File uploads: handle upload errors #197

winged opened this issue Jul 7, 2021 · 1 comment

Comments

@winged
Copy link
Contributor

winged commented Jul 7, 2021

When a file upload fails (for example, file size too large), a document still is created, but for obvious reasons cannot be downloaded.

First, we need to make the error more prominent in the frontend, so the user will notice something went wrong.

Second, and more importantly, we need to think about handling the error:

A) in a new upload, we may delete the document again. Which component triggers this is yet to-be determined. I could think about the backend checking file presence after a while, or the frontend explicitly checking the upload's success and taking appropriate measures.

B) When uploading a new version, only the file in the document may be deleted

@Yelinz
Copy link
Member

Yelinz commented Apr 4, 2024

Addressed by #507

Largest problem with the empty document is fixed, but smaller ones may still persist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants