Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

fix codegen check to work properly on release branches #463

Closed
skriss opened this issue Oct 25, 2021 · 1 comment
Closed

fix codegen check to work properly on release branches #463

skriss opened this issue Oct 25, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@skriss
Copy link
Member

skriss commented Oct 25, 2021

This includes the CRD changes from projectcontour/contour#4135, unfortunately the codegen check does not work properly on release branches.

Originally posted by @skriss in #462 (comment)

When on a release branch, I believe we should run codegen with NEW_VERSION=<release branch name> which should sync Contour CRDs from the corresponding Contour release branch. Need to double-check that this doesn't have any other unwanted side effects.

@skriss skriss changed the title Update codegen check to work properly on release branches fix codegen check to work properly on release branches Oct 25, 2021
@skriss skriss added the duplicate This issue or pull request already exists label Feb 3, 2022
@skriss
Copy link
Member Author

skriss commented Feb 3, 2022

Duplicate of #432

@skriss skriss marked this as a duplicate of #432 Feb 3, 2022
@skriss skriss closed this as completed Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant