Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour crashes on startup when globalExtAuth extension service doesn't exist. #6768

Open
xyzzyz opened this issue Nov 19, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@xyzzyz
Copy link

xyzzyz commented Nov 19, 2024

What steps did you take and what happened:
When you configure Contour to use globalExtAuth service, pointing it to ExtensionService that doesn't exist, it will crash on startup:

time="2024-11-18T23:51:20Z" level=fatal msg="Contour server failed" error="error getting extension service lattice/authx-external: extensionservices.projectcontour.io \"authx-external\" not found"

This is problematic for initial deployment setup: usually, the extension service will only be created later, after Contour is already installed, so Contour will keep crashlooping until something creates that service. I don't think that this behavior is necessary: we already have configuration fields specifying what to do when the global auth extension service is not responding (failOpen). We could simply treat the missing ExtensionService same as the extension service not responding.

What did you expect to happen:
I expect Contour to just start normally when ExtensionService specified in globalAuthExt doesn't exist, and then treat the incoming requests according to behavior configured in failOpen.

Anything else you would like to add:

// ensure the specified ExtensionService exists
is where the check is done

Environment:

  • Contour version: 1.31
@xyzzyz xyzzyz added kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Nov 19, 2024
Copy link

Hey @xyzzyz! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Development

No branches or pull requests

1 participant