Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of metrics URL in client for security #44

Open
snarlysodboxer opened this issue Mar 9, 2019 · 1 comment
Open

Allow override of metrics URL in client for security #44

snarlysodboxer opened this issue Mar 9, 2019 · 1 comment

Comments

@snarlysodboxer
Copy link
Contributor

Some use cases require being able to protect against a bad actor on the proxy side. E.G. someone with access to the proxy could send valid yet malicious requests through the client, defeating the purpose of the network barrier.

For example, if I run node-exporter and mysql on the same machine, running the client on that machine would allow access to mysql by a compromised prometheus environment. I think many people's security requirements won't allow that.

How do you feel about a patch that adds a backwards compatible --override-url option to the client?

#41 has no feedback, thus creating this issue.

@brian-brazil
Copy link
Contributor

It'd expected that you'll protect the proxy. The whole purpose of this application is to get around network obstacles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants