Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_exporter: Systemd service unit uses incorrect template, leading to ProtectHome bug #95

Open
cudevmaxwell opened this issue May 3, 2023 · 1 comment
Open

node_exporter: Systemd service unit uses incorrect template, leading to ProtectHome bug #95

cudevmaxwell opened this issue May 3, 2023 · 1 comment

Comments

@cudevmaxwell
Copy link
Contributor

Issue #13 was never really fixed. I incorrectly assumed something about the behavior of scopes in Jinja2 templates. Thank you @tjdavis3 for uncovering this problem. Fixed in #94, which uses jinja2's namespaces to ensure variable change propagates. I wanted to use something nicer like python's any() or something more clever, but at least it won't be broken.
@cudevmaxwell cudevmaxwell changed the title node_exporter: Systemd service unit uses incorrect template, leading to PretectHome bug node_exporter: Systemd service unit uses incorrect template, leading to ProtectHome bug May 3, 2023
@cudevmaxwell cudevmaxwell mentioned this issue May 3, 2023
Closed
@cudevmaxwell
Copy link
Contributor Author

This issue was fixed in #94 but tests are still forthcoming in #101. Keeping open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cudevmaxwell