Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--const-label (and most likely other features) don't work #108

Open
colega opened this issue Nov 5, 2024 · 0 comments · May be fixed by #113
Open

--const-label (and most likely other features) don't work #108

colega opened this issue Nov 5, 2024 · 0 comments · May be fixed by #113

Comments

@colega
Copy link

colega commented Nov 5, 2024

--const-label flag does nothing in v0.6.0, I see in the code that arg is parsed in to labelKeys and labelValues which are not used for anything:

avalanche/metrics/serve.go

Lines 503 to 507 in 6246210

labelKeys := make([]string, c.cfg.LabelCount)
for idx := 0; idx < c.cfg.LabelCount; idx++ {
labelKeys[idx] = fmt.Sprintf("label_key_%s_%v", strings.Repeat("k", c.cfg.LabelLength), idx)
}
labelValues := make([]string, c.cfg.LabelCount)

They were used in v0.5.0, so I guess this broke somewhere in between v0.5.0 and v0.6.0
@tamareyal tamareyal linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --const-label option tamareyal/avalanche
1 participant
@colega