Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What support should a maintainer/project expect from prometheus-community? #10

Open
RichiH opened this issue Aug 29, 2018 · 8 comments
Open

Comments

@RichiH
Copy link
Member

RichiH commented Aug 29, 2018

Do we want to offer anything specific?

What immediately comes to mind is access to infrastructure for testing and such.

@simonpasquier
Copy link

Yes I see that a consistent and shared CI infrastructure makes it easier to keep up with the changes to the CI provider(s) as it has been experienced with GitHub integrations, Circle CI 1.0 → 2.0 and so on.

Also:

  • Dedicated website?
  • Binaries should be at least available from the GitHub release pages. Do they deserve a dedicated page similar to https://prometheus.io/download/?
  • Container image hosting?
  • Common tooling for releasing artifacts (part of CI probably).

@carlpett
Copy link

It was mentioned either in the mail thread or in the other issue here that major changes to "how things are done" could also be something which is done in a sweep over everything in this org (for example as the switch to Kingpin on the main org was done, and the upcoming suggested TLS implementations)

@roidelapluie
Copy link
Contributor

  • regular vendor upgrade and releases

@carlpett
Copy link

@roidelapluie Isn't that going to be the job of the maintainers? Doing vendor updates and releases requires some amount of care and knowledge of the workings of the exporter, in my mind, rather than just bulk updating everything.

@roidelapluie
Copy link
Contributor

That is untrue.

Vendor updates takes mainly good unit and acceptance testing.

@roidelapluie
Copy link
Contributor

roidelapluie commented Aug 29, 2018

Plus everyone in the org is a maintainer in my vision.

@carlpett
Copy link

I'd agree that a good acceptance test coverage would reduce risk. However, I think this is lacking in a significant majority of exporters? I wouldn't say creating them is simple either, in most cases it would require setting up a fair chunk of infrastructure and exercising (which may in some cases also have a non-trivial financial impact).

@brian-brazil
Copy link

However, I think this is lacking in a significant majority of exporters?

The JMX exporter is the only one I know of with testing to this level. Some of the push-ones like influxdb/statsd/graphite probably also count. (Node exporter has extensive testing, but I'm not counting it here as it's running against fake data rather than a real kernel, and doesnt cover all OSes either).

Updating something like Kingpin can be done in bulk, updating libraries related to an exporter's key role less so. It's the same issue we have with SD and notifiers.

@SuperQ SuperQ transferred this issue from prometheus-community/prometheus-community Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants