Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a infra CLI command to get the prombench service endpoints #436

Closed
wants to merge 2 commits into from
Closed

Adding a infra CLI command to get the prombench service endpoints #436

wants to merge 2 commits into from

Conversation

imrajdas
Copy link
Contributor

@imrajdas imrajdas commented Sep 5, 2020 •
edited
Loading

List of services endpoints

  • Grafana: http://<IP>:<PORT>/grafana
  • Prometheus: http://<IP>:<PORT>/prometheus-meta
  • Logs: http://<IP>:<PORT>/grafana/explore

fixes: #427

@imrajdas
Copy link
Contributor Author

imrajdas commented Sep 5, 2020

cc @geekodour

@imrajdas imrajdas changed the title Adding infra CLI to get services of prombench Adding a infra CLI command to get the prombench service endpoints Sep 5, 2020
geekodour
geekodour reviewed Sep 16, 2020
View reviewed changes
pkg/provider/kind/kind.go

NodePort = service.Spec.Ports[0].NodePort

fmt.Printf("Grafana: http://%v:%v/grafana\n", InternalIP, NodePort)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than printing the services I think we should just simply print the InternalIP and NodePort and one could use the README to see whatever service the want. :) We primarily want the InternaIP and NodePrort here so.

@bwplotka
Copy link
Member

👋🏽 Looks like there was no activity on this PR for some time, closing for now, we can always reopen if still relevant/to-be-reviewed. Thanks!

@bwplotka bwplotka closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekodour geekodour geekodour left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a new infra cli command to print the exposed services
3 participants
@imrajdas @bwplotka @geekodour