-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add https certificate for http://prombench.prometheus.io/ #724
Comments
Hi, I’d like to work on this issue. Should I use cert-manager for automated TLS, or would you prefer creating a Secret with the key and certificate? |
We’d have to rotate it, right? So it should be automated. |
Yes, exactly. Cert-Manager automates certificate rotation, so once it's set up, it will handle renewals for us. Going with that. |
The Cert Manager setup is failing due to some NGINX configuration right now, (I Suppose, Still investigating). E1102 18:43:02.885272 1 sync.go:208] "propagation check failed" err="wrong status code '404', expected '200'" logger="cert-manager.controller" resource_name="prometheus-meta-1-3643360222-881729279" resource_namespace="default" resource_kind="Challenge" resource_version="v1" dnsName="prombench.prometheus.io" type="HTTP-01" The Solver pod is unable to reach the challenge at the |
I raised a PR to add an HTTPS certificate to prombench.prometheus.io using Cert-Manager and Let's Encrypt. I'm facing some DNS issues during local testing. With some tweaks, I managed to solve the ACME challenge and issue the certificate locally, but if there's a more streamlined way to test this setup, any guidance would be appreciated. |
Aside from being generally good practice, I hit this when I wanted to point https://demo.promlens.com/ at http://prombench.prometheus.io/prometheus-meta/; it refuses to talk to non-https endpoints.
The text was updated successfully, but these errors were encountered: