Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related items appear in wrong place in group discussions #5

Open
jondron opened this issue Dec 17, 2014 · 3 comments
Open

Related items appear in wrong place in group discussions #5

jondron opened this issue Dec 17, 2014 · 3 comments

Comments

@jondron
Copy link

jondron commented Dec 17, 2014

When set to appear after comments, which works well across all other post types, related items actually appear between the discussion post and the comment box in group discussions.
Great plugin, BTW, apart from that minor issue!

@propertunist
Copy link
Owner

thanks! i disabled group discussions on my site here so haven't tested much with it. i have now re-enabled that feature so will look at this and fix it soon.

@jondron
Copy link
Author

jondron commented Apr 20, 2015

Those discussions are pesky! In 1.9, line 3 of related_items/views/default/related_items/related_items.php causes a WSOD as there appears to be no subtype method for discussion posts. I changed this line to:

if(!elgg_in_context('discussion') && in_array($vars['entity']->getSubtype(),$renderto_subtypes))

which simply prevents it from kicking in for discussions

@propertunist
Copy link
Owner

i have been stuck with elgg here since i have not been able to upgrade my site without also getting several key plugins upgraded (which are coded by other coders).. so i haven't looked at upgrading/fixing my plugins from 1.8 to above. i am getting round to doing this now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants