Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22 make publish ignore example packages #23

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

forgetso
Copy link
Member

No description provided.

@forgetso forgetso linked an issue Nov 28, 2023 that may be closed by this pull request
Copy link

Pull Request Report

Hey there! I've analyzed the changes in the pull request and here's a report for you:

Changes

  1. Updated the command in README.md to use npx typechain-polkadot instead of npx @prosopo/typechain-polkadot. (Line 17)

Suggestions

I have a couple of suggestions to improve the code:

  1. In examples/plugins/package.json and examples/psp22/package.json, you can remove the "private": true property since it's already set in the root package.json. (Lines 6-10, 22-26)

Bugs

I couldn't find any potential bugs in the code. Great job!

Improvements

I found a couple of places in the code that could be refactored for better readability:

  1. In examples/psp34/package.json and examples/psp34_enumerable/package.json, you can move the "publishConfig" object to the top of the file for better organization. Here's the updated code snippet:
{
  "name": "psp34",
  "version": "1.0.0",
  "publishConfig": {
    "access": "restricted"
  },
  "private": true,
  "description": "",
  "main": "index.js",
  "scripts": {
    "generate": "npx typechain-polkadot --in ./artifacts --out ./out",
    "start": "ts-node index.ts"
  },
  "dependencies": {
    "@prosopo/typechain-polkadot": "1.1.13",
    "@prosopo/typechain-types": "1.1.13",
    "@types/node": "^18.8.0",
    "ts-node": "^10.7.0",
    "typescript": "^5.2.2",
    "@polkadot/api": "10.11.1",
    "@polkadot/api-contract": "10.11.1",
    "@types/bn.js": "^5.1.0"
  },
  "author": "Supercolony-net",
  "license": "ISC"
}

Rating

I would rate the code a 7 out of 10. The code is generally readable and well-structured. However, there are a few areas where it could be improved for better readability and organization.

That's it for the report! Let me know if you need any further assistance. Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make publish ignore example packages
1 participant