-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix queries and tx integrations #29
base: main
Are you sure you want to change the base?
Conversation
@ical10 thanks for the PR! Is the format below (
How does polkadotJs apps pluck the event name from the |
Hi @forgetso
This isn't defined anywhere in the metadata, but this is coming from the new format inside
Not sure about how it exactly works. In any case, in order to get the typesafe tx call working, we need to "grab" only |
@ical10 thanks for the explanation. I just want to make sure that the string format is always going to be the same so the code always works. Having read it a bit more closely, I can see the code works if there are no You'll need to get the tests working in order to merge. Please also make this a variable instead of writing it twice:
Otherwise, looks good! :) |
Sorry for the delay. I've added your feedbacks, also ran the tests and all passed. |
Issues
We are trying to integrate this package into our project
ink!athon
, but ran into some issues (scio-labs/inkathon#64).The issues are:
Expected Results
It should work seamlessly without any issues. This PR aims to solve it.
In addition, I added a sample contract in our boilerplate as an example, created some tests for it, and checked that other tests still pass.
cc @forgetso @wottpal