Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Idea #3

Open
hgn opened this issue Aug 28, 2017 · 2 comments
Open

Trace Idea #3

hgn opened this issue Aug 28, 2017 · 2 comments
Assignees

Comments

@hgn
Copy link
Member

hgn commented Aug 28, 2017

The idea is that tracepoints can be enabled via command line argument. A list of strings can be passed via

--trace=TRACEPOINT1,TRACEPOINT2

which is passed to the router constructor:

Router(args, str(i), interfaces=interfaces,
            tracepoints=self.args.trace.split(","), trace_directory=XXX,
            mm=mm, log_directory=ld)

Default is disabled tracing (thus, self.args.trace.split(",") will not work if no argument is given). Just an example.

See tracepoint and trace_directory as additional arguments.
E.g. there: https://github.com/protocollabs/dmpr-simulator/blob/master/dmpr-simulator.py#L944

To pass enabled tracepoints to the command line allows us to start tests with distinct tracepoints without modifying the source code.

@reisub-de
Copy link
Contributor

Implemented in newest dmpr-core, see #5

@reisub-de
Copy link
Contributor

Can be closed

reisub-de pushed a commit to reisub-de/dmpr-simulator that referenced this issue Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants