Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive/Dockerfile used to build visor images #18

Open
4 tasks
vistrcm opened this issue May 11, 2021 · 0 comments
Open
4 tasks

archive/Dockerfile used to build visor images #18

vistrcm opened this issue May 11, 2021 · 0 comments

Comments

@vistrcm
Copy link
Contributor

vistrcm commented May 11, 2021

Summary of Bug

Hello,
It looks like archive/Dockerfile used to build cosmovisor images instead of visor/Dockerfile.
GithubActions configured to use docker/node/archive/Dockerfile for both archive and visor images.

Archive: https://github.com/provenance-io/testnet/blob/main/.github/workflows/docker.yml#L41
cosmovisor: https://github.com/provenance-io/testnet/blob/main/.github/workflows/docker.yml#L49

Because of that changes like 08304a7 have no effect.

Possible fix: #19

Version

GitHash c1dc285

Steps to Reproduce

Visor Docker image build in https://github.com/provenance-io/testnet/runs/2546680132?check_suite_focus=true#step:7:76
sha: 71dd4c9759f9eb776ff59b90a7c3753191c276b18e394a1620702213041042fe
do not include visor changes for docker-entrypoint.sh

docker run -it provenanceio/node@sha256:71dd4c9759f9eb776ff59b90a7c3753191c276b18e394a1620702213041042fe cat /docker-entrypoint.sh
#!/usr/bin/env bash

# No config dir yet, create it.
if [ ! -d "${PIO_HOME}/config" ]; then
  mkdir -p "${PIO_HOME}/config"
fi

# No data dir yet, create it
if [ ! -d "${PIO_HOME}/data" ]; then
    mkdir "${PIO_HOME}/data"
fi

# If custom genesis.json is not provided, use the default.
if [ ! -f "${PIO_HOME}/config/genesis.json" ]; then
  cp "/${CHAIN_ID}/genesis.json" "${PIO_HOME}/config/genesis.json"
fi

# If custom config.toml is not provided, use the default.
if [ ! -f "${PIO_HOME}/config/config.toml" ]; then
  cp "/${CHAIN_ID}/node-config.toml" "${PIO_HOME}/config/config.toml"
fi

# If custom app.toml is not provided, use the default.
if [ ! -f "${PIO_HOME}/config/app.toml" ]; then
  cp "/${CHAIN_ID}/node-app.toml" "${PIO_HOME}/config/app.toml"
fi

exec "$@"

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant