Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL for interrupt setup #86

Open
wavexx opened this issue Aug 13, 2021 · 4 comments
Open

HAL for interrupt setup #86

wavexx opened this issue Aug 13, 2021 · 4 comments
Assignees
Labels

Comments

@wavexx
Copy link
Collaborator

wavexx commented Aug 13, 2021

We currently have to include <avr/interrupt.h> to setup the interrupts, which is not portable.
Some minimal HAL for interrupts would avoid having to include AVR-specific parts in the code.

@leptun
Copy link
Collaborator

leptun commented Aug 13, 2021

Can’t really setup interrupts in c++ directly. We probably need to use macros for defining interrupts.

@wavexx
Copy link
Collaborator Author

wavexx commented Aug 13, 2021

I think that's fine. But we need something, otherwise we have to use ifdefs when we setup interrupts for AVR. I'm trying to setup the motion ones, and I had to add several because the same code is also built for the tests, and there you don't ISR(), or the __vector definitions either.

@wavexx
Copy link
Collaborator Author

wavexx commented Aug 13, 2021

On the PC it might simply expand to nothing, just so that it builds. Not sure if @DRracer has better ideas.

@wavexx wavexx added the api label Aug 16, 2021
@github-actions
Copy link

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@wavexx wavexx self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants