-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove webkit as a mandatory run/build-time dependency #12968
Comments
Not sure what WebView is used for, but if there is an option to just turn off this functionality in full to make wxGTK webkit dependency optional - it would be great. |
2276ced first bad commit |
+10
I'll better stay on 2.7 |
WebKit, like all HTML/JS engines, is prone to regular security vulnerabilities, and therefore banned from most of my machines. +1 to removing the mandatory dependency. |
I'm not using Prusa Connect or anything, but I killed all the webkit instances and the slicer still works fine. It would also be nice to see these instances to only be spawned if the user has done something that requires them (logging in, clicking the login button, etc), as they some of them have a non-zero CPU usage when idle. |
+1 for making the webkit components optional. Though I approach this from a slightly different perspective. For source based Linux distros (Gentoo family, LFS, etc), pulling in webkit is a big compile time commitment which is exacerbated by semi-frequent security updates. Admittedly, compile time is little more than an annoyance, but it is annoying to add hours of time to regular system updates, especially for a feature not being used. The security angle is probably more compelling, since there are unavoidable considerations of embedding web technologies and loading external content. I did poke around in the code (it has been nearly 20 years since I've touched cmake, and I'm not a c[++] dev by trade), and it looks like this is sort of a tangled mess, and it doesn't look like it will be straightforward to |
The new webkit UI is incredibly buggy and nearly useless. I have to literally restart the app after every sliced model, or it stops updating the UI. webkit needs to go. |
why is noone solving this problem? prusa-slicer is starting to become worst slicer of all from performance point of view and developers/maintainers are dead silent about this problem. CPU usage when doing nothing has always to be 0% |
Hello @buhman, thank you for your report! Issue created: SPE 2512 |
I wrote a patch to just #if all of the webview code out a couple weeks ago that works well enough and just breaks the cloud functionality. Will take a bit more work to put all of it behind a feature gate and hide all the cloud print stuff, it's a bit messy, but it can be done. |
@cynicalcervine where I can find your patch? |
@gordon-quad just uploaded into the
|
@cynicalcervine your commit looks pretty good. Do you think it's high enough quality to submit as a pull request here? |
@buhman maybe, but they'd probably want a bit more work done on it to make it so that none of the online functionality is enabled at all when you turn off the feature as right now it will show a login box that just does nothing. It would just involve a couple more #ifdefs sprinkled in where necessary. |
I've upgraded prusaslicer to 2.8.1 and now it refuses to even start when it doesn't have permission to launch the browser:
|
@cynicalcervine Sadly, your patch does not work with 2.8.1. |
+1 Local only, Web browsers are a thing YOUR better than them stop trying to be them |
Installing a web browser inside your 3D model slicer is insane. I have a web browser, if I need it I'll use it, I promise. Is it within scope to add a compiler and infrastructure to download, configure and compile firmware? Seriously. It's a slicer. It doesn't need a food processor attachment. Stop spending your time on the shoe polisher. This is beyond feature creep. If this isn't addressed, I'll stop using PrusaSlicer. I haven't used another slicer since Skeinforge, and if I leave I won't look back. No big loss, but I'm not alone. Most of the compelling features in this slicer have come from outside this project recently anyway. |
Agreed. This added a hell of a lot of issues with distribution, building, compiling and operation of a slicer. Rip out the web browser completely from PrusaSlicer and bring it back to what it actually is - a slicer. Time to reverse the enshittification of PrusaSlicer before it gets even more out of hand. |
If you must keep the tabs for printables and local printer how about just having them open in my browser. Tons of other apps do this for opening web content. This is even how most of the item in the help menu work already so the code is even here todo it. The only "web" thing i want to be able todo from the slicer is upload gcode to my printer. |
Looks like this is a bug in unpatched 2.8.1. Fixed with:
|
Can we please, please, please have at least an options level toggle to NOT have printables and physical printer tabs in the slicer. My web browser is very good at managing system-hog pages that I'm not currently engaged with. I'm quite happy to alt-tab between prusaslicer and and a web browser and close the browser when i don't need to poke my printer. I also have about 20 printables tabs open. I don't need that in my slicer. I just need my slicer to not fall over on my i7-8565U laptop with only 16GiB of ram. It should be plenty for this. A "fix" for kilpper users is to specify the moonraker port, so I set |
@cynicalcervine @luke-jr -- they closed #13635 as "completed" because they fully intend to continue to chase profits at the expense of an acknowledged but unvalued portion of their userbase. Are either of you going to / willing to keep a repo up to date for this? If I need to change slicers, I'd rather start now. |
@strayr -- The answer is a definitive hard no. #13635 was just closed, asking for specifically that.
But what about PrusaSlicer's profits? Those poor profits.
Thank you for this, I'll be implementing it until I find a replacement slicer. Does anyone have any suggestions? I'm guessing OrcaSlicer is where PrusaSlicer got the idiot idea of integrating a browser in the first place, what else is there? |
I didn't ask about disabling downloads, getting an STL straight to PS is
cool. I just want the web browser in my slicer gone. It's an absolute
performance killer. And all it takes is one mis-click and it's there.
I mean I could block printables on my local net as I usually browse through
a VPN, but that's a little extreme.
I'd be sticking with 2.7 or an ancient build of super slicer if I was still
on a really feeble machine. It really shouldn't be the case that PS uses
more resources than Fusion because someone thought it would be a good idea
to embed a web browser in it that I can't turn off.
Just let me turn it off at runtime. Please.
…On Mon, 6 Jan 2025, 18:03 CodeFaux, ***@***.***> wrote:
Can we please, please, please have at least an options level toggle to NOT
have printables and physical printer tabs in the slicer.
@strayr <https://github.com/strayr> -- The answer is a definitive hard
no. #13635 <#13635> was just
closed, asking for specifically that.
I don't need that in my slicer. I just need my slicer to not fall over on
my i7-8565U laptop with only 16GiB of ram. It should be plenty for this.
But what about PrusaSlicer's profits? Those poor profits.
A "fix" for kilpper users is to specify the moonraker port, so I set
fastprinter.local:7125 as the URL and the physical printer page shows a
very minimal moonraker info page.
Thank you for this, I'll be implementing it until I find a replacement
slicer.
Does anyone have any suggestions? I'm guessing OrcaSlicer is where
PrusaSlicer got the idiot idea of integrating a browser in the first place,
what else is there?
—
Reply to this email directly, view it on GitHub
<#12968 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKIYU2D7MRZ77TPCPUFIXVD2JLAP3AVCNFSM6AAAAABKDK64ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTGYZTIMJRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sadly that's probably not something I'll do into the future. I'll likely update my fork if I really have to, but it's good on features for now and there's nothing I really need out of it. Eventually there probably will be, I'll chase some feature I really want (like variable print height with organic supports or something), and then if this is the direction the prusa team is going down I'll probably just end up picking a different slicer myself when I really need it :( Sad to see them doing this in such a sloppy way. It was like 2 hours of work to just put everything behind a build flag. It's not even that it would be super hard to maintain just this one patch, but it looks like they plan on integrating even more with web stuff going forward. |
Enshittification rarely is reversed once its started. I would strongly suggest to the community to start looking at alternatives, or coordinate to maintain a fork. |
Thanks for the update. I figured this was likely the case. Between Prusa and a few other apps recently shittifying themselves and the EOL/update pressure/shittifying direction of Win10, I recently abandoned it (NEVER Windows 11) and moved to main Linux. I'm forced to use the PrusaSlicer Flatpak while I look for a new solution, as I'm not prepared to just shut down in the mean time. The flatpak shits the bed and freezes any time I accidentally click either the Physical Printer or Printables tabs, and it can't access my /mnt/win folder where all the models live for now because it's a flatpak and not an actual application which means everyone ELSE gets to decide what permissions I have with it, so I'm beyond doubly driven to find a replacement. Do you have thoughts on candidates?
Yeah, that's pretty much the one. Their reply to the other read as "shareholders agree that this is the way moving forward but I can't say that out loud" and it just fully made me lose interest. The good features come from other slicers, the shit comes from above. The main thing they're worried with is digesting it and making the profit needle move. There will soon be no Prusa community; they're viewed as just a pool of consumers. |
Please tell if there's a PrusaSlicer ←→ SuperSlicer configuration directory converter. |
For what its worth, the PrusaSlicer 2.7.5 AppImage works just fine in all respects. There's very little added since that is a 'must have' to force an upgrade. |
Yeah thanks for the tip. I actually recently found out about AppImage with my CAD software. I'm impressed with it. It makes it really obvious how much bloated BS you add to an app though, so I can see why PrusaSlicer would want to hide that set of holiday photos, so to speak. Wait..did they remove 2.7.5 from Github? All I see is 2.7.5-rc1 presently.
Disagree. Multiple bed / bulk export is a small bonus for me. Scarf Seams has made a -HUGE- improvement in print visual quality. Came from OrcaSlicer, but OrcaSlicer embraces a lot of things I don't want too. No corporate [censored] going on, so that's a plus, but it's almost a lateral move in "unwanted extras" to me. |
@l29ah -- My understanding is they're the same except the new features, so the expected practice is to copy the settings folders from PrusaSlicer into SuperSlicer and it should just work. This may help; |
One more +1 to this. Runtime switch would be okay. Compile-time switch would be perfect. |
Is your feature request related to a problem? Please describe.
I originally bought my Prusa printers specifically because, unlike other vendors, there was no "cloud" feature.
It is unreasonable that Webkit is a mandatory build-time/run-time dependency, and it should be possible to compile PrusaSlicer such that all mention of "Prusa Connect" is removed entirely.
Describe the solution you'd like
Add a new Cmake option, for example
SLIC3R_WEBKIT
and/orSLIC3R_PRUSACONNECT
. When cmake is given with an invocation such ascmake -DSLIC3R_WEBKIT=OFF
, the compiled binaries should have no link/load dependencies on Webkit nor a wxGTK that has webview compiled-in. All buttons and menu options that refer to "Prusa Connect" should be removed if these options are OFF.Describe alternatives you've considered
Stay on 2.7.4 forever.
The text was updated successfully, but these errors were encountered: