Fix Bugs in PeerDAS Testing (#14396)

* Fix Various Bugs in PeerDAS * Remove Log * Remove useless copy var. --------- Co-authored-by: Manu NALEPA <[email protected]>
prysmaticlabs · Aug 29, 2024 · 8cd37ab · 8cd37ab
1 parent bd7ec3f
commit 8cd37ab
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/beacon-chain/core/peerdas/helpers.go b/beacon-chain/core/peerdas/helpers.go
@@ -1,6 +1,7 @@
 package peerdas
 
 import (
+	"context"
 	"encoding/binary"
 	"fmt"
 	"math"
@@ -145,16 +146,24 @@ func DataColumnSidecars(signedBlock interfaces.ReadOnlySignedBeaconBlock, blobs
 	}
 
 	// Compute cells and proofs.
-	cellsAndProofs := make([]kzg.CellsAndProofs, 0, blobsCount)
+	cellsAndProofs := make([]kzg.CellsAndProofs, blobsCount)
 
+	eg, _ := errgroup.WithContext(context.Background())
 	for i := range blobs {
-		blob := &blobs[i]
-		blobCellsAndProofs, err := kzg.ComputeCellsAndKZGProofs(blob)
-		if err != nil {
-			return nil, errors.Wrap(err, "compute cells and KZG proofs")
-		}
+		blobIndex := i
+		eg.Go(func() error {
+			blob := &blobs[blobIndex]
+			blobCellsAndProofs, err := kzg.ComputeCellsAndKZGProofs(blob)
+			if err != nil {
+				return errors.Wrap(err, "compute cells and KZG proofs")
+			}
 
-		cellsAndProofs = append(cellsAndProofs, blobCellsAndProofs)
+			cellsAndProofs[blobIndex] = blobCellsAndProofs
+			return nil
+		})
+	}
+	if err := eg.Wait(); err != nil {
+		return nil, err
 	}
 
 	// Get the column sidecars.

diff --git a/beacon-chain/sync/subscriber.go b/beacon-chain/sync/subscriber.go
@@ -711,6 +711,10 @@ func (s *Service) subscribeDynamicWithColumnSubnets(
 	genesis := s.cfg.clock.GenesisTime()
 	ticker := slots.NewSlotTicker(genesis, params.BeaconConfig().SecondsPerSlot)
 
+	wantedSubs := s.retrieveActiveColumnSubnets()
+	for _, idx := range wantedSubs {
+		s.subscribeWithBase(s.addDigestAndIndexToTopic(topicFormat, digest, idx), validate, handle)
+	}
 	go func() {
 		for {
 			select {