Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POWChainService should be renamed #14639

Open
james-prysm opened this issue Nov 14, 2024 · 1 comment · May be fixed by #14643
Open

POWChainService should be renamed #14639

james-prysm opened this issue Nov 14, 2024 · 1 comment · May be fixed by #14643
Labels
Cleanup Code health!

Comments

@james-prysm
Copy link
Contributor

james-prysm commented Nov 14, 2024 •
edited
Loading

💎 Issue

Background

we have this service called POWChainService, I think this should be renamed to ExecutionChainService or something related to represent connection with the execution client since we are post merge.
what's also confusing is it's called web3Service in some places.

Description
@james-prysm james-prysm added the Cleanup Code health! label Nov 14, 2024
@james-prysm james-prysm linked a pull request Nov 20, 2024 that will close this issue
Draft
3 tasks
@rkapka
Copy link
Contributor

rkapka commented Nov 20, 2024

It would be nice to rename everything containing ETH1 in the name too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup Code health!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

beacon node: renaming functions and services to better reflect what they do prysmaticlabs/prysm
2 participants
@rkapka @james-prysm