From 77258a4f5c20a8217d9fae7ebdefab030007d143 Mon Sep 17 00:00:00 2001 From: Pau Ruiz Safont Date: Wed, 8 Jan 2025 10:04:29 +0000 Subject: [PATCH] database: do not log when a field is dropped when loading from db_xml It causes logspam and hasn't been useful in the years it's been present. Lowering it to a debug statement would still cause it to be logged, so drop the message completely instead. Signed-off-by: Pau Ruiz Safont --- ocaml/database/db_xml.ml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/ocaml/database/db_xml.ml b/ocaml/database/db_xml.ml index d7c73db3d84..1795cdef3bd 100644 --- a/ocaml/database/db_xml.ml +++ b/ocaml/database/db_xml.ml @@ -161,12 +161,9 @@ module From = struct D.warn "no lifetime information about %s.%s, ignoring" tblname k ; false in - if do_not_load then ( - D.info - {|dropping column "%s.%s": it has been removed from the datamodel|} - tblname k ; + if do_not_load then row - ) else + else let column_schema = Schema.Table.find k table_schema in let value = Schema.Value.unmarshal column_schema.Schema.Column.ty