-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulling in community updates #6
base: master
Are you sure you want to change the base?
Conversation
- p_req vs p_nom - PDD mode - rounded values in testing
Updates for WNTR 0.3.0
- pnom to preq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections to most of these changes.
I see that the tests haven't been passing. |
@pshassett |
@jhogge thanks for the quick response. I suppose the benchmark values just need to be updated then. |
Hi all, yes we are seeing minor changes between WNTR and EPANET simulator. Additionally, with the change of WNTR incorporating EPANET 2.2, we have gotten slightly different pressure results for the criticality runs since @pshassett ran them. The recent PR only changes the segment indexing so I'm not sure why this specific PR would show errors for you but the November one did not. I re-cloned @jhogge's repo today and pushed the index change. |
Thanks for keeping this alive and up-to-date with the progress of WNTR.