Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yaml-cpp #111

Closed
humbertodias opened this issue Feb 20, 2024 · 2 comments · Fixed by #117
Closed

add yaml-cpp #111

humbertodias opened this issue Feb 20, 2024 · 2 comments · Fixed by #117

Comments

@humbertodias
Copy link

Would be possible to add the library yaml-cpp?
https://github.com/jbeder/yaml-cpp.git

Thanks

@sharkwouter
Copy link
Member

It would be and it wouldn't be too hard. yaml-cpp needs a small change to get it to build:

--- CMakeLists.txt	2024-02-21 09:55:58.709903787 +0100
+++ yaml-cpp-0.8.0/CMakeLists.txt	2023-08-10 21:27:56.000000000 +0200
@@ -84,7 +84,7 @@
   PROPERTY
     CXX_STANDARD_REQUIRED ON)
 
-if (NOT YAML_BUILD_SHARED_LIBS AND NOT PSP)
+if (NOT YAML_BUILD_SHARED_LIBS)
   set_property(TARGET yaml-cpp PROPERTY POSITION_INDEPENDENT_CODE ON)
 endif()
 

With that it builds just fine using psp-cmake.

You can find some documentation on how to make packages here: https://github.com/pspdev/psp-packages/blob/master/CONTRIBUTING.md

Feel free to make a PR, otherwise I can see if I can get to this somewhere next week.

@humbertodias
Copy link
Author

Thanks.
I have submitted a fix jbeder/yaml-cpp#1271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants