Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddListings is missing check to prevent duplicate #10

Open
0xTranqui opened this issue Oct 2, 2022 · 3 comments
Open

AddListings is missing check to prevent duplicate #10

0xTranqui opened this issue Oct 2, 2022 · 3 comments

Comments

@0xTranqui
Copy link
Member

@iainnash from some initial local UI testing, it looks like addListings is missing a check to prevent duplicate listings from showing up. with the new data structure maybe we can't actually prevent this? would be great if we could, will give it a shot later today

@iainnash
Copy link
Contributor

iainnash commented Oct 2, 2022

If we want to use an extra data write to hash the addListings for each listing and check for duplicates we can but does add extra on-chain overhead. Users can delete duplicates or admins can – front-ends can also dedupe.

@0xTranqui
Copy link
Member Author

if we were to prevent dups on front end, do u imagine it looks something like:

  • fetch all current listings
  • compare new listings to be added to see if they are already included onchain
  • prevent txn from being sent if there is a match?

@iainnash
Copy link
Contributor

iainnash commented Oct 3, 2022

Yep exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants