Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condense burn + burnBatch functions? #12

Open
0xTranqui opened this issue Oct 2, 2022 · 5 comments
Open

Condense burn + burnBatch functions? #12

0xTranqui opened this issue Oct 2, 2022 · 5 comments

Comments

@0xTranqui
Copy link
Member

@iainnash any reason we cant condense burn + burnBatch functions so that you are always passing in array of inputs, similar to what we did with the addListings function?

burning functionality is present on lines 231-242 of curator.sol

@iainnash
Copy link
Contributor

iainnash commented Oct 2, 2022

The reason we keep both functions and the name of burn is a user can remove a listing from zora marketplace / opensea just by burning the NFT.

@0xTranqui
Copy link
Member Author

0xTranqui commented Oct 2, 2022

are you saying burnBatch doesn't achieve the same thing?

@iainnash
Copy link
Contributor

iainnash commented Oct 3, 2022

marketplaces look for burn(uint) as the function signature to call for burn. just keeping w/ the informal standard for allowing standard uis to work as expected with both functions.

@iainnash
Copy link
Contributor

iainnash commented Oct 7, 2022

Upon reading more of the README do we want to do burn(uint) and removeListings(uint[])

@0xTranqui
Copy link
Member Author

I think we should keep it just as burn so as to lean into the fact that you can use indexers to find all active listings at any point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants