-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condense burn + burnBatch functions? #12
Comments
The reason we keep both functions and the name of burn is a user can remove a listing from zora marketplace / opensea just by burning the NFT. |
are you saying burnBatch doesn't achieve the same thing? |
marketplaces look for |
Upon reading more of the |
I think we should keep it just as burn so as to lean into the fact that you can use indexers to find all active listings at any point |
@iainnash any reason we cant condense burn + burnBatch functions so that you are always passing in array of inputs, similar to what we did with the addListings function?
burning functionality is present on lines 231-242 of curator.sol
The text was updated successfully, but these errors were encountered: